Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SigmaHQ validator to use diskcache for dynamic data loading instead of static generated Python files. The changes improve the architecture by:
- Implementing disk caching for remote JSON data from the SigmaHQ repository
- Splitting Windows validator data into separate eventid and provider JSON files
- Removing dead code including the config system and data generation scripts
- Updating validators to use the new data loading modules
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sigma/validators/sigmahq/data/data_taxonomy.py | New module for loading and caching taxonomy data with disk cache |
| sigma/validators/sigmahq/data/data_filename.py | New module for loading and caching filename pattern data |
| sigma/validators/sigmahq/data/data_windows_eventid.py | New module for Windows EventID validation data |
| sigma/validators/sigmahq/data/data_windows_provider.py | New module for Windows provider validation data |
| sigma/validators/sigmahq/fieldname.py | Updated to use new data_taxonomy module instead of config |
| sigma/validators/sigmahq/logsource.py | Updated to use new data_taxonomy module |
| sigma/validators/sigmahq/filename.py | Updated to use new data_filename module |
| sigma/validators/sigmahq/detection.py | Updated to use new Windows data modules |
| sigma/validators/sigmahq/modifier.py | New module containing field duplicate and all modifier validators |
| tools/sigmahq_windows_eventid.json | New JSON file separating EventID validation data |
| tools/sigmahq_windows_provider.json | Updated JSON file with only provider data |
| json-schema/schema_sigmahq_windows_eventid.json | New JSON schema for EventID validation |
| json-schema/schema_sigmahq_windows_provider.json | Updated schema removing eventid field |
| tests/* | Updated test imports from field to fieldname/modifier modules |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Test will not pass as the json are not in the main branch by now 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breack logic to use diskcache in v0.30.0