Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds correlation support to this repo. AKA once this is merged correlation rules will be supported and allowed to be merged in SigmaHQ rules repo.
This PR will start by migrating some correlations that were submitted in the past as well as establishing the necessary conventions and standard.
There is a corresponding validator PR SigmaHQ/pySigma-validators-sigmaHQ#60 that has to be merged.
As well as a new sigmahq-convention for correlations. SigmaHQ/sigma-specification#196
Below is a list of old PRs and rules that shoule be migrated / investigated as part of this initial MVP
We also have rules written in the old notation sitting in the unspported folder. Frack already did some initial work last year. See below:
Changelog
TBD
Example Log Event
N/A
Fixed Issues
N/A
SigmaHQ Rule Creation Conventions