update: DNS Query to External Service Interaction Domains - Add domains change modifier #5823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darses
changed the title
rules/network/dns/net_dns_external_service_interaction_domains.yml
Outdated
Show resolved
Hide resolved
swachchhanda000
added
the
Author Input Required
swachchhanda000
approved these changes
Jan 5, 2026
swachchhanda000
removed
the
Author Input Required
swachchhanda000
requested review from
Copilot,
frack113,
nasbench and
phantinuss
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DNS Query to External Service Interaction Domains detection rule by adding three new OAST (Out-of-Application Security Testing) domains and changing the matching modifier from contains to endswith for more precise domain matching.
Key Changes:
- Changed the query modifier from
containstoendswithto prevent false positives from substring matches - Added three new OAST domains:
.digimg.store,.instances.httpworkbench.com, and.odiss.eu - Added clarifying comments to identify the service providers for various OAST domains
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frack113
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add new OAST domains and set modifier to
endswith.Changelog
update: DNS Query to External Service Interaction Domains - Add domains digimg.store, instances.httpworkbench.com, odiss.eu.
update: DNS Query to External Service Interaction Domains - Change modifier from contains to endswith
Example Log Event
Fixed Issues
SigmaHQ Rule Creation Conventions