Skip to content

Revert "feat: add database to store conversation"#1044

Merged
clementb49 merged 1 commit intomasterfrom
revert-1041-convDatabase
Feb 17, 2026
Merged

Revert "feat: add database to store conversation"#1044
clementb49 merged 1 commit intomasterfrom
revert-1041-convDatabase

Conversation

@clementb49
Copy link
Collaborator

@clementb49 clementb49 commented Feb 17, 2026

Reverts #1041

Summary by CodeRabbit

  • Removed Features
    • Persistent conversation storage removed. Conversations must now be manually saved to files.
    • Conversation history feature removed.
    • Auto-save draft functionality removed.
    • Automatic reopening of last conversation on startup removed.
    • Privacy toggle setting removed.

@clementb49 clementb49 merged commit b471680 into master Feb 17, 2026
8 of 9 checks passed
@clementb49 clementb49 deleted the revert-1041-convDatabase branch February 17, 2026 12:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes the entire conversation database persistence layer, including the SQLAlchemy ORM models, Alembic migrations, database manager, and related UI features. Configuration options for auto-save and last conversation reopening are eliminated, along with their dependencies on SQLAlchemy and Alembic.

Changes

Cohort / File(s) Summary
Database Infrastructure Removal
basilisk/conversation/database/__init__.py, basilisk/conversation/database/manager.py, basilisk/conversation/database/models.py, basilisk/conversation/database/alembic/*
Removed complete database persistence layer: database manager class with CRUD operations (755 lines), SQLAlchemy ORM models for conversations/messages/attachments/citations (205 lines), Alembic migration environment configuration, initial schema migration, and Mako template. Eliminates all persistent storage and retrieval logic.
Configuration & Model Updates
basilisk/config/main_config.py, basilisk/conversation/attached_file.py, basilisk/conversation/conversation_model.py, .gitignore
Removed four ConversationSettings fields (auto_save_to_db, auto_save_draft, reopen_last_conversation, last_active_conversation_id) and deleted db_id field from AttachmentFile and message models (SystemMessage, MessageBlock). Stopped tracking Claude settings file in git.
UI Layer Changes
basilisk/gui/conversation_history_dialog.py, basilisk/gui/conversation_tab.py, basilisk/gui/main_frame.py, basilisk/gui/preferences_dialog.py
Deleted ConversationHistoryDialog (225 lines); removed database scaffolding and draft-handling workflow from ConversationTab (272 lines removed); eliminated conversation history menu, privacy toggle UI, and auto-reopen-last-conversation logic from MainFrame (95 lines removed); removed three checkbox controls from preferences dialog (auto-save settings).
Application Initialization
basilisk/main_app.py
Removed database initialization and cleanup methods (init_conversation_db, close_conversation_db) and their associated imports; eliminated database setup/teardown in app lifecycle.
Dependencies & Tests
pyproject.toml, tests/conftest.py, tests/conversation/database/*
Removed sqlalchemy and alembic dependencies; deleted all database-related test fixtures and test modules (conftest.py with 122 lines, test_manager.py with 470 lines, test_models.py with 465 lines, test_roundtrip.py with 310 lines); removed conversation_with_response fixture.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • AAClause
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-1041-convDatabase

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant