Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull request overview
This PR restructures the top “Gloss Detail View” tables by splitting the initial rows into separate tables so the “main” fields at the end (notably useInstr and wordClass) can be formatted with fewer columns and more space.
Changes:
- Split the initial combined table into multiple tables (Senses/Add sense, Synsets, then Main fields).
- Reworked the rendering of
main_fieldsto explicitly formatuseInstrandwordClassin a fixed-width table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1860,19 +1861,17 @@ <h2 id='modalTitleGloss'>{% trans "Add a sense" %}</h2> | |||
| </span><br> | |||
| {% endfor %} | |||
There was a problem hiding this comment.
The Synsets table row opens a <td> (line 1850) but never closes it before the </tr> (line 1863). This produces invalid HTML and can cause the following tables to be nested incorrectly depending on browser auto-correction. Add the missing </td> before closing the row.
Suggested change
| {% endfor %} | |
| {% endfor %} | |
| </td> |
Woseseltops
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table rows at the beginning of Gloss Detail View have been split into separate tables to allow specific formatting of the "main" fields at the end (below Synset, fields "useInstr" and "wordClass". These were being crowded because of three columns used in the rows above. These only need two.
In doing this I made the two fields be hard-coded. There was some weird stuff going on with "too much generic looping in the template". It's also not allowed to use "value" inside of a "td" element. (All of the gloss editing does this.)
@Woseseltops can you try to add this to ASL to see if it resolves the bug? It's on
signbank-test.I ended up only including the two "main" fields. I can't revise the formatting because there is no form for these fields. (As far as Signbank Global goes, there are only two fields here.)