-
Notifications
You must be signed in to change notification settings - Fork 46k
fix(frontend): fix builder's page dynamic title #11090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Refactored BuilderPage to utilize MainBuilderPage component for better structure. - Enhanced metadata generation in the page to dynamically set titles based on flowID and flowVersion. - Removed legacy FlowEditor component and related onboarding logic for cleaner code. - Improved error handling for missing graph data to ensure consistent user experience.
Here's the code health analysis summary for commits Analysis Summary
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
… flowID and flowVersion - Updated the `generateMetadata` function in `page.tsx` to await the `searchParams` promise, ensuring correct extraction of `flowID` and `flowVersion`. - This change improves the reliability of metadata generation for the BuilderPage component.
The issue we’re facing is that we have Next.js metadata in
layout.tsx
that sets the title of the entire application. It’s a default title, but we need the dynamic document title for the builder’s page. Since the builder’s page is client-side, we useuseEffect
anddocument.title
for this purpose. However, there’s a problem with this approach. Initially, we mount the title, but as we hydrate the server-side metadata, it gets removed and replaced with the layout’s default title.Changes 🏗️
Tests