-
Notifications
You must be signed in to change notification settings - Fork 46.2k
feat(platform): Backend completion of Onboarding tasks #11375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…into kpczerwinski/secrt-1727-onboarding-notifications
…into kpczerwinski/secrt-1727-onboarding-notifications
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
3039e20 to
69cb8a1
Compare
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
0ubbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, nice cleanp Front-end side 👍🏽 💯
Make onboarding task completion backend-authoritative which prevents cheating (previously users could mark all tasks as completed instantly and get rewards) and makes task completion more reliable. Completion of tasks is moved backend with exception of introductory onboarding tasks and visit-page type tasks.
Changes 🏗️
source, so appropriate tasks can be completedclient.tsapi calls with orval generated and remove no longer used functions fromclient.tsresolveResponsehelper function that unwraps orval generated call result to 2xx responseSmall changes&bug fixes:
Checklist 📋
For code changes: