Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.0 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntindle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.0 #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ beautifulsoup4==4.14.2
# Async support
asyncio
asyncpg==0.30.0
urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@sentry sentry bot Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Adding urllib3>=2.6.0 breaks installation on Python 3.8, which contradicts the project's documented support for Python 3.8+.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The project's documentation claims support for Python 3.8 and higher. This pull request introduces a dependency on urllib3>=2.6.0, which requires Python 3.9 or later. This will cause a pip dependency resolution failure for any user attempting to install the project on a Python 3.8 environment, directly contradicting the documented system requirements. The CI pipeline does not test against Python 3.8, so this breaking change was not detected automatically.

💡 Suggested Fix

To resolve this, either update the documentation to reflect that Python 3.9+ is the new minimum required version, or downgrade the urllib3 requirement to a version compatible with Python 3.8 to maintain the currently documented support.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: requirements.txt#L35

Potential issue: The project's documentation claims support for Python 3.8 and higher.
This pull request introduces a dependency on `urllib3>=2.6.0`, which requires Python 3.9
or later. This will cause a `pip` dependency resolution failure for any user attempting
to install the project on a Python 3.8 environment, directly contradicting the
documented system requirements. The CI pipeline does not test against Python 3.8, so
this breaking change was not detected automatically.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7957237

Loading