Brd4350a support#235
Closed
sarthak shaha (Sarthak-Shaha) wants to merge 830 commits intorelease_2.5-1.4from
Closed
Brd4350a support#235sarthak shaha (Sarthak-Shaha) wants to merge 830 commits intorelease_2.5-1.4from
sarthak shaha (Sarthak-Shaha) wants to merge 830 commits intorelease_2.5-1.4from
Conversation
…d add tests to CI (#36718) * TC_DeviceBasicComposition: Fix lighting-app-data-mode-no-unique-id and add to CI This PR fixes Basic Composition failures on the lighting-app-data-mode-no-unique-id examples app add the test to CI to prevent it from breaking again. This App is already built in CI, so it shouldn't add much CI cost. * Add other app tests to CI * removed flaky fabric app
…rs/codegen` (#36752) * Move codegen provider to data-model-providers/codegen to not place it within app directly * Restyle * Fix paths with minimal change --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* Don't use default ctor for ChipDeviceEvent * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…) when using the stdio logging backend (#36764) * [Darwin] Print the queue name (or a shorter version for common queues) when using the stdio logging backend * [darwin-framework-tool] Print the queue name (or a shorter version for common queues) when logging
* Fixing typos * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…mand (#36774) * [Fabric-Sync] Add --enable-icd-registration option to pair-device command * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* python testing: add test functions for IDs - Add functions to say whether an ID is in the standard range - simpify API to accept an int ID rather than the enum since this is how they appear on the device. - fix tests TEST: see unit test * Update src/python_testing/matter_testing_infrastructure/chip/testing/global_attribute_ids.py Co-authored-by: Andrei Litvin <andy314@gmail.com> --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Adding type protection here * Restyled by clang-format * Safer way to do this * Restyled by clang-format * Fixing format * Restyled by clang-format * Adding error * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…(#36794) * Added string builder adaptesr for chip::System::Clock::Microseconds64 and Milliseconds64 * Restyled by clang-format * Cast the time to llu because some platforms use lu. * Added exception for chrono to check_includes_config.py --------- Co-authored-by: Restyled.io <commits@restyled.io>
…iring a value (#36786)
…IG_ENABLE_PAIRING_AUTOSTART" with generated configuration (#36778) Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
When this was originally written the idea was that the TH would run these tests unconditionally and the test itself would indicate if it ran. This works well in the CI and we still want to maintain this mechanism since it will allow us to automate test selection more easily down the road. However, the time required to even start a test in the TH is significant. With the way the test harness is set up currently, adding unconditional tests adds a significant amount of time to testing, even if the tests don't run. For now, let's bring back at least cluster-level gating. We can still gate internally on cluster elements for the CI. This isn't ideal, but it's where we are now.
This exposes the following: * Dishwasher Alarm cluster. * Dishwasher Mode cluster, except the OnOff feature bit and the StartUpMode and OnMode attributes, which are marked X in the specification, and the generic mode tags, which might not end up being part of the cluster in the long term. * Door Lock cluster unbolt/unlatch bits. * ICD Management cluster (note: the deprecated Key field in MonitoringRegistrationStruct is not present in the SDK XML, so there is no need to explicitly exclude it). * Laundry Washer Controls cluster. * Laundry Washer Mode cluster, except the OnOff feature bit and the StartUpMode and OnMode attributes, which are marked X in the specification, and the generic mode tags, which might not end up being part of the cluster in the long term. * Microwave Oven Control cluster. * Microwave Oven Mode cluster, except the OnOff feature bit, which are marked X in the specification, and the generic mode tags, which might not end up being part of the cluster in the long term. * Oven Mode cluster, except the OnOff feature bit and the StartUpMode and OnMode attributes, which are marked X in the specification, and the generic mode tags, which might not end up being part of the cluster in the long term. * Oven Cavity Operational State cluster, except the Pause and Resume commands, which are marked X in the specification, and the enums which are not actually part of the cluster in the spec. * Refrigerator And Temperature Controlled Cabinet Mode cluster, except the OnOff feature bit and the StartUpMode and OnMode attributes, which are marked X in the specification, and the generic mode tags, which might not end up being part of the cluster in the long term. * Refrigerator Alarm cluster. * RVC Operational State cluster GoHome command. * RVC Run Mode cluster Mapping mode tag. * Temperature Control cluster. And removes the following stale provisional annotations, because the corresponding items have been removed from the XML: * RVC Clean Mode's OnMode attribute and OnOff feature bit. * RVC Run Mode's OnMode attribute and OnOff feature bit. * RVC Operational State's Start/Stop commands. * EventList attribute. * Barrier Control cluster bits. * General Diagnostics' AverageWearCount attribute.
* [Fabric-Admin] Reset PairingManager state before next command * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Fabric-Sync] Synchronize all required attributes * Revert commit 8126bbd * Synchronize all required attributes
…reads (#36812) Fixes #36803
* esp32: Optimize WiFi Scan Handling with Single AP Record API * esp32: add separate ScanResponseIterator for new API changes * esp32: enable ESPScanResponseIterator for compatible IDF versions * esp32: add call for clear ap scan list, used single name for iterator * esp32: move iterator release call outside, code refactoring * esp32: relocate iternum variable for iterator compatibility with older IDF versions * Make SetApData() method private
* Check fabric-sync application with MCORE-FS tests on CI * Add test with new fabric-sync for MCORE-FS-1.5 * Use async-friendly sleep
…p (#36800) Remove duplicate EnergyTimeUtils.h include in EVSEManufacturerImpl.cpp
* Re-validate submodules when labels are modified * Reformat help text
Minor modification in the command description to account for the removal of an argument in the Spec.
…… (#37104) * da_revocation: fix serial number formatting in revocation set generation script Also update test data to ensure 2-byte alignment * add comment explaining the change * update comment
* Pin the Restyler version to v0.6.0.2 * Remove new name tags
* ESP32: Remove the same configs as defaults * resolve comments
Takes mypy errors down from 79 to 27. Nearly all remaining are
related to Enum - mypy has support for Enum functions, but it seems
like the derived classes are messing it up. Can be addressed
in a followup - this is still better.
The goal here is mostly to tighten up the type annotations and
move int -> uint for ids where possible, such that the spec
parsing is providing data with a stronger guarantee.
Testing: Tested by TestSpecParsing.py and TestSpecParsingDeviceTypes.py
Also used by tests run in CI (including above)
* Avoid PW-RPC assertion error if application is stopped without any RPC connections * Anoter PWRPC crash fix * Implement the write from TLV * Update protos to support string and bytes as separate types for encode/decode * Restyle * make writes actually work * Make write(read.tlv) actually work * Fix typo
* Added fix for ncp init issue * Removed commented code * Removed unused variables * Resolved review comments * Reverted sl_board_configuration.h header include * Resolved review comments * Added latest sdk_support pointer and resolved review comments * Added comment for SPI transfer API * Disabled lcd and external flash in silabs_boards.gni for 917 NCP board * Added TODO for removing disabling lcd and enable external flash * TODO added properly in silabs_board.gni file --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
…th a size_t pathsConfig.count (#37173) in reality pathsConfig.count will never exceed 255 but since this is TestCode simplest is to make the loop condition index a size_t
…ath, ListBuilder &)` (#37127) * Append-only API update: use CHIP_ERROR and builders for MetadataTree * Fix includes * Remove odd comment * ScopedSpan == ReadOnlyBuffer and Build == TakeBuffer * Update src/app/InteractionModelEngine.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/data-model-provider/MetadataList.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Replaced a lot of auto with const auto for readability * Update src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Remove old comment * Fix some typos * Fix typo * Update src/app/data-model-provider/MetadataTypes.h Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* [SL-UP] Add provisioning root argument (#231) * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
…37165) This affects how NSUInteger is bridged into Swift when building locally.
… invoke timeout. (#37179) We should log what happened to the work item, not just silently complete it.
… ription work (#37177)
* Darwin: Tidy up some device type meta-data classes - Move MTRDeviceTypeRevision out of ServerEndpoint directory - Move MTRProductIdentity into its own file - Implement NSCopying and equality on MTRDeviceType and MTRProductIdentity - Implement description on all 3 types - Add tests * Darwin: Add MTRCommissioningParameters.readEndpointInformation Endpoint information is made availalable to the delegate via an MTRCommissioneeInfo object containing MTREndpointInfo objects. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Use NSString literal for MTRDeviceTypeData * Process endpoints in best-effort fashion even with invalid / missing DeviceTypeList Also add some additional comments to parsing logic and a couple more tests. * Address further review comments for Darwin layer * Move MTRCommissioneeInfo into its own set of files * Make MTRCommissioneeInfo and related types conform to NSSecureCoding Also conform to NSCopying, mark as sendable, and implement isEqual/hash. * Fix terminology a bit. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* da_revocation: added dac_provider test vectors These test vectors support testing with sample revocation sets. * dac_revocation: device attestation revocation user guide This document lists the process for testing device attestation revocation using the dac provider test vectors sample revocation sets. * Restyled by whitespace * Restyled by prettier-markdown * Match the enum string with correct value in the doc --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Move MockTestRunner to chip testing package * Fix script dir path * Remove unused import
Fix broken link to test scripts
sarthak shaha (Sarthak-Shaha)
changed the base branch from
main
to
release_2.5-1.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added support for BRD4150A , updated matter_support submodule
Updated Matter_Support submodule
Testing
Builds locally, running CI