-
Notifications
You must be signed in to change notification settings - Fork 31
[SL-TEMP] Validate Unit Test report generation and upload steps #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
senthilku
wants to merge
13
commits into
release_2.6-1.4
Choose a base branch
from
update/unit_test_testreport_test
base: release_2.6-1.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables code coverage generation and upload in the unit/integration test workflow.
- Adds coverage and debug flags to the GN configuration step
- Introduces steps to generate and upload code coverage reports
- Retains TODOs for future log upload enhancements
Comments suppressed due to low confidence (4)
.github/workflows/unit_integration_test.yaml:77
- [nitpick] The GN generation flags are growing long and hard to read. Consider defining a separate variable or using a multiline YAML block for clarity and easier future updates.
scripts/build/gn_gen.sh --args="$GN_ARGS chip_data_model_check_die_on_failure=true use_coverage=true is_debug=true"
.github/workflows/unit_integration_test.yaml:82
- Test reports (e.g., JUnit XML) are not being generated or uploaded. Consider configuring your test runner to produce report files and use
actions/upload-artifactto make them available for CI analysis.
- name: Run Code Coverage
.github/workflows/unit_integration_test.yaml:85
- Piping a remote script via
curlcan be a security risk and is not pinned to a version. Consider using the official Codecov GitHub Action (e.g.,codecov/codecov-action@v3) for a more secure and reliable upload.
run: bash <(curl -s https://codecov.io/bash)
.github/workflows/unit_integration_test.yaml:85
- The Codecov upload step does not reference a
CODECOV_TOKENor other authentication. Ensure the upload is authenticated using repository secrets to avoid failures.
run: bash <(curl -s https://codecov.io/bash)
updated upload code coverage report step
Co-authored-by: Copilot <[email protected]>
6f26239 to
35a5a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests are built and run for each PR, but test reports are not generated or uploaded for further analysis. Enable test report generation in the PR
Testing
CI/CD