Skip to content

Conversation

@senthilku
Copy link
Contributor

Description

Unit tests are built and run for each PR, but test reports are not generated or uploaded for further analysis. Enable test report generation in the PR

Testing

CI/CD

@senthilku senthilku requested review from a team and Copilot June 26, 2025 00:34
@senthilku senthilku marked this pull request as draft June 26, 2025 00:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables code coverage generation and upload in the unit/integration test workflow.

  • Adds coverage and debug flags to the GN configuration step
  • Introduces steps to generate and upload code coverage reports
  • Retains TODOs for future log upload enhancements
Comments suppressed due to low confidence (4)

.github/workflows/unit_integration_test.yaml:77

  • [nitpick] The GN generation flags are growing long and hard to read. Consider defining a separate variable or using a multiline YAML block for clarity and easier future updates.
                  scripts/build/gn_gen.sh --args="$GN_ARGS chip_data_model_check_die_on_failure=true use_coverage=true is_debug=true"

.github/workflows/unit_integration_test.yaml:82

  • Test reports (e.g., JUnit XML) are not being generated or uploaded. Consider configuring your test runner to produce report files and use actions/upload-artifact to make them available for CI analysis.
            - name: Run Code Coverage

.github/workflows/unit_integration_test.yaml:85

  • Piping a remote script via curl can be a security risk and is not pinned to a version. Consider using the official Codecov GitHub Action (e.g., codecov/codecov-action@v3) for a more secure and reliable upload.
              run: bash <(curl -s https://codecov.io/bash)

.github/workflows/unit_integration_test.yaml:85

  • The Codecov upload step does not reference a CODECOV_TOKEN or other authentication. Ensure the upload is authenticated using repository secrets to avoid failures.
              run: bash <(curl -s https://codecov.io/bash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants