[SL-TEMP] Validate Unit Test report generation and upload steps #530
+62
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables coverage report generation and upload for unit tests by integrating Codecov for project and patch coverage tracking.
- Adds XML coverage report generation capability alongside existing HTML reports
- Integrates Codecov upload step in the CI/CD workflow with coverage requirements
- Configures Codecov with 60% patch coverage target and project coverage monitoring
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/build_coverage.sh | Adds gcovr installation and XML coverage generation with --xml flag |
| .github/workflows/unit_integration_test.yaml | Enables coverage build flags and adds Codecov upload step |
| .github/codecov.yml | Configures Codecov with project and patch coverage requirements |
Comments suppressed due to low confidence (1)
scripts/build_coverage.sh:44
- The gcovr version 8.3 may not exist. As of my knowledge cutoff in January 2025, gcovr's latest version was around 6.x. Please verify this version exists or use a known stable version.
pip3 install gcovr==8.3
| if_ci_failed: ignore | ||
| patch: | ||
| default: | ||
| target: 60% # Require 80% patch coverage |
There was a problem hiding this comment.
The comment says 'Require 80% patch coverage' but the target is set to 60%. The comment should be updated to match the actual target value.
Suggested change
| target: 60% # Require 80% patch coverage | |
| target: 60% # Require 60% patch coverage |
Comment on lines
+41
to
+47
| _install_gcovr() { | ||
| if ! gcovr --version >/dev/null 2>&1; then | ||
| echo "gcovr not installed. Installing..." | ||
| pip3 install gcovr==8.3 | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] The _install_gcovr function should be called after its definition. Currently it's defined but never invoked until line 298, which could lead to confusion about when gcovr gets installed.
Suggested change
| _install_gcovr() { | |
| if ! gcovr --version >/dev/null 2>&1; then | |
| echo "gcovr not installed. Installing..." | |
| pip3 install gcovr==8.3 | |
| fi | |
| } | |
| # _install_gcovr invocation moved closer to its definition for clarity.() { | |
| if ! gcovr --version >/dev/null 2>&1; then | |
| echo "gcovr not installed. Installing..." | |
| pip3 install gcovr==8.3 | |
| fi | |
| } | |
| _install_gcovr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enabling project coverage and patch coverage for PR's
Testing
CI/CD