Draft/renode ci #599
Draft
Draft/renode ci #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update ZoneManagement cluster xml to latest Spec * Update zcl json files and run zap regen * Restyle fixes
Co-authored-by: Andrei Litvin <[email protected]>
* first trial * Adding Test Cases Bad Signature fails CASE * fixing comment * integrating comments * merging both testcases into one * Adding fault injeciton macro
* Start some documentation on writing clusters * More updates * Add file * Restyle * Fix typos * Fix links * Restyled by prettier-markdown * fix link * Update docs/guides/writing_clusters.md Co-authored-by: Boris Zbarsky <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Boris Zbarsky <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Sergio Soares <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Sergio Soares <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Sergio Soares <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Boris Zbarsky <[email protected]> * Update docs/guides/writing_clusters.md Co-authored-by: Boris Zbarsky <[email protected]> * Remove line numbers from markdown file * Add clarification * Clarity updates * More details --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Sergio Soares <[email protected]>
* TI directory structure and CC2674 support updates * lock app readme update and misc cleanup * resolve merge conflict in lock-app CHIPProjectConfig.h and gemini comments in ICD readme and ti_simplelink_executable.gni * corrected backticks in pump controller readme * Restyled by clang-format * Restyled by gn * Restyled by autopep8 * Fixed CI job fails * Restyled by prettier-markdown * fixes for failing documentation and lint jobs * more fixes for failing doc job * empty commit --------- Co-authored-by: Restyled.io <[email protected]>
* Improve enable/disable of Wi-Fi PAF for build_python.sh This change: - Removes dead code related to Soft-AP in SetUpCodePairer - Removes non-normalized logs related to PAF that confused readers that PAF was enabled when it's not - Add a flag to build_python.sh to disable Wi-Fi PAF - Disable IPv4 by default in build_python.sh (which was supposed to be the case a long time ago), to match the config of chip-tool for certification builds. - Add a way to add additional `--gn_args` to the command line so that we don't have to special case every config for python builds, and so that trials to test Python controller changes are easier to build. - Fixed a couple cut'n'paste mistakes in build_python.sh and SetUpCodePairer.cpp that were seen during the PR workflow. Testing done: - Ran certification tests in Python with `--enable_wifi_paf false` and no longer see the Wi-Fi PAF logs about errors to run it (since it's not an error if it's not implemented). - Tested `scripts/build_python.sh -i out/python_env --gn_args 'chip_crypto="mbedtls"' and validated the the gn command line (via a `set -x`) has the correct argument and that the crypto backend is replaced by mbedtls. * Fix review comment * Update scripts/build_python.sh * Address comments from @bzbarsky-apple * Restyled by clang-format * Update scripts/build_python.sh * Update scripts/build_python.sh --------- Co-authored-by: Restyled.io <[email protected]>
…instead of <!-- sequence (#39420) * Fix PR validation * update error message * error message clarity
…ck address matching IP type (#39429)
…ging group connections (#39432)
…rces when make is called for QPG builds. (#39425)
…ich can happen if something goes wrong during Init (#39428)
* Remove the need to allocate stack memory when removing an entry from persistence * Remove internal dependency on TableEntry, instead referencing data & id directly
* Separate out the scan response encoding from the single cpp file * Undo unintentional changes * Move load-responses as static/inline since this seems to save almost 100 bytes of flash on a NXP build * Add some silly unit tests (because we can) and double-protect against null pointers * Restyle * Look to fix tizen initializers * Look to fix tizen initializers * Rename stuff * Just a copy and paste for now ... * Code compiles. Correctness may be dodgy however it compiles! * Start adding more TODO part for handling metadata. Code keeps compiling * more handling covered in the cluster (and have logic expose the commands public * Restyle * Start implementing attribute handling. This will take a while... * Attribute handling ported over * Fix up attribute metadata reports * Command handling * make tye path logic a bit more sane * Remove null network driver as it is not used by anything * Added conditional includes to for the encoding * More cleaning ... should be ready for "instance" soon * Start adding a codegen instance * Restyle * Use the shim ... is it converted? * Fix wrong pragma in cpp file * Add ember required functions * Avoid gcc error about shadowing * Save more bytes for conditional attributes * make attributes be AAI-only for network commissioning * Remove ScanResponseEncoder as these are old test files, not used * Added some lifetime data * Fix tests * Fix PDC code * Remove fixme * One more PODC update * Fix typo * Fix typo * Restyle * Move handle query identity to PDC as well * Clean stale comment * Fix up cmake files * Zap regen * Added better unit tests ... no functionality change though even though it feels odd... * Switch from RSS to LQI * Fix LQI ordering instead of RSSI * Restyle * Add vector include * Undid functional change * Added issue link * Restyled by clang-format * Remove usage of accessors in NXP ... those do not make sense * Massive hack to make ESP32 link * Adding global attributes as well * Remove odd workaround as ESP32 dependencies are now fixed * Start preparing unit tests. Required privilege seems to bind us to codegen * Restyled by clang-format * Restyled by gn * Compile fixes and regen for zap * Fix unit tests * Fix typos * Fix typos * More spellcheck fixes * Do not lint testing folders * Fix nrf monolith tests as well ... boy this coupling is ugly * Restyle and fix some old code. Tests should be ok now (I hope) * Restyled by whitespace * Make equal attribute sets be part of a cpp file, to make linker happy for monoliths * Fix dependencies * Fix includes * Fix includes * Undo esp32 change - not relevant * more test fixes * REALLY NASTY workaround for ESP32 ... this is until we fix 39441 ... --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* Add VendorIdVerificationSigner cert support to SDK
- Add VendorIdVerificationSigner direct support to src/credentials.
- Includes adding missing OIDs and direct methods to generate
and identify such certificate types.
- Add support to the `chip-cert` tool to process/generate these
certificates.
- Includes fixing minor error-handling bugs and log wording in chip-cert.
- Added inner CHIPLog support to avoid dropping helpful error messages
on the floor.
Testing done:
- Added unit tests for the new methods in CHIPCert.h/.cpp module,
including round-trip tests.
- Manually tested chip-cert against VVSC and RCAC in the Matter
spec repos test vectors. Prior to changes, verification failed
as expected.
```
tennessee@tennessee1:~/repos/connectedhomeip-spec-tcv/src/crypto_primitives/vid_verify_data$ chip-cert validate-cert --trusted-cert vid_signer_root_cert.pem vid_signer_cert.pem
tennessee@tennessee1:~/repos/connectedhomeip-spec-tcv/src/crypto_primitives/vid_verify_data$ echo $?
0
tennessee@tennessee1:~/repos/connectedhomeip-spec-tcv/src/crypto_primitives/vid_verify_data$ chip-cert convert-cert --chip vid_signer_cert.pem vid_signer_cert.tlv
tennessee@tennessee1:~/repos/connectedhomeip-spec-tcv/src/crypto_primitives/vid_verify_data$ chip-cert convert-cert --chip vid_ vid_signer_cert.tlv
tennessee@tennessee1:~/repos/connectedhomeip-spec/src/crypto_primitives/vid_verify_data$ chip-cert print-cert vid_signer_root_cert.tlv
CHIP Certificate:
Signature Algo : ECDSAWithSHA256
Issuer : [[ OrganizationName = Acme LLC,
CommonName = VID FFF1 Vendor verification root,
MatterRCACId = 11223344AABBCCDD ]]
Not Before : 0x2FCCC3EB ( 2025/05/30 19:30:51 )
Not After : 0xEBC4E1EB ( 2125/05/06 19:30:51 )
Subject : [[ OrganizationName = Acme LLC,
CommonName = VID FFF1 Vendor verification root,
MatterRCACId = 11223344AABBCCDD ]]
Public Key Algo : ECPublicKey
Curve Id : prime256v1
Public Key : 04 C3 72 05 4D 6B 08 9B BF E4 6B CF 48 64 09 ED
53 73 ED C5 65 14 1C FF 5A F2 F8 32 2F 22 6D 33
CE 26 F4 6D E2 CA 2F 06 8B 66 46 C3 64 C2 4E 2E
6E 5B C1 8B 2F 2A E3 46 5A FE 32 1C D9 05 69 5D
53
Extensions:
Is CA : true
Path Length Const: 2
Key Usage : DigitalSignature KeyCertSign CRLSign
Subject Key Id : 10 52 A9 D8 2F 5E DB 97 A6 C4 5E CF 25 C9 91 8B A3 50 50 01
Authority Key Id : 10 52 A9 D8 2F 5E DB 97 A6 C4 5E CF 25 C9 91 8B A3 50 50 01
Signature : 7F 1F 72 E6 E5 9A 7A DE 0D A9 21 DB 53 2A 7E 17
F0 CE 68 D3 04 46 E0 A2 8E D3 84 14 9D 46 85 1B
19 A5 92 50 F3 92 D8 EE 40 F0 55 BF DC 1A 87 E6
60 95 92 23 8D E9 AC AB E6 C7 98 F0 89 73 E4 B3
tennessee@tennessee1:~/repos/connectedhomeip-spec-tcv/src/crypto_primitives/vid_verify_data$ chip-cert print-cert vid_signer_cert.tlv
CHIP Certificate:
Signature Algo : ECDSAWithSHA256
Issuer : [[ OrganizationName = Acme LLC,
CommonName = VID FFF1 Vendor verification root,
MatterRCACId = 11223344AABBCCDD ]]
Not Before : 0x2FCCC3EB ( 2025/05/30 19:30:51 )
Not After : 0x4298C6EB ( 2035/05/28 19:30:51 )
Subject : [[ OrganizationName = Acme LLC,
CommonName = VID FFF1 Vendor verification signer 1,
MatterVidVerificationSignerId = BBEEDDEE00112233 ]]
Public Key Algo : ECPublicKey
Curve Id : prime256v1
Public Key : 04 9E C0 A3 6C B9 3C 01 35 79 F2 9E D3 60 4E A9
8E 14 40 99 36 C5 59 7A 50 14 D9 6E 1D 77 88 CB
55 19 F8 D8 80 6F E8 96 40 F8 A8 75 9D 4D 35 9B
78 30 D4 4A A2 44 E7 B8 71 DC 71 3B B5 59 12 16
7D
Extensions:
Is CA : false
Key Usage : DigitalSignature
Subject Key Id : FA C0 E7 D0 08 94 73 F1 5C 2D FE FE 54 6F FF A0 B0 0A 8B B2
Authority Key Id : 10 52 A9 D8 2F 5E DB 97 A6 C4 5E CF 25 C9 91 8B A3 50 50 01
Signature : 7E 35 E8 21 33 74 5D 43 40 99 D0 2A 3B 56 A8 7A
65 61 9E 63 22 FA 85 20 1A 87 72 75 5B 2A CB 16
AA 83 64 EE 93 63 83 40 2C 5B 91 3E 4F 40 EA C7
D6 92 61 66 38 B0 1B E5 DD CA 1D EF 01 3B FC 3E
```
* Restyled by clang-format
* Restyled by prettier-markdown
* Address review comments
* Restyled by clang-format
* De-fuse a clang-tidy "code mine"
- Some bad (but legal) pattern existed in chip-cert tool source
related to how unique_ptr<uint8_t []> are initialized.
- This blew-up with clang-tidy errors and there's more lurking.
- I fixed all of them so the next person touching chip-cert
doesn't need to deal with it.
* Restyled by clang-format
* Fix some clang-tidy left
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <[email protected]>
Add space to find targets command
…(#39445) * Move random data version in startup * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
* Alchemy generation of Identify cluster * Add ZAP generated files for Identify cluster * Regenerate cluster XML without in-progress attribute * Regenerate with ZAP after merging code from master branch * Test change in workflow for labels * Revert test change in workflow for labels
* Generate Microwave Oven XML using Alchemy * Add ZAP generated files
…> DnssdError (#39438)
…lper to log IPv6 addresses with interface scope instead of using nw_endpoint_copy_address_string() (#39436)
… and match incoming packets by interface in Connections (#39430)
* Fix access levels of ThreadNetworkDirectory cluster This aligns the ZAP XML with the changes from CHIP-Specifications/connectedhomeip-spec#10159 Fixes #39174 * zap_regen_all
Bumps [third_party/simw-top-mini/repo](https://github.com/NXP/plug-and-trust) from `2e9189d` to `afda1e6`. - [Release notes](https://github.com/NXP/plug-and-trust/releases) - [Commits](NXP/plug-and-trust@2e9189d...afda1e6) --- updated-dependencies: - dependency-name: third_party/simw-top-mini/repo dependency-version: afda1e65891b0f226ee141ccc277eb60c3b6bb14 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/lwip/repo](https://github.com/lwip-tcpip/lwip) from `ca0395c` to `56b29f8`. - [Commits](lwip-tcpip/lwip@ca0395c...56b29f8) --- updated-dependencies: - dependency-name: third_party/lwip/repo dependency-version: 56b29f8bcfaefe2974dca67bde16cc7c391feaeb dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add cleanup step to CADMIN-1.19 * Restyled by isort --------- Co-authored-by: Restyled.io <[email protected]>
…452) Bumps [third_party/libdatachannel/repo](https://github.com/paullouisageneau/libdatachannel) from `0e40aeb` to `a81daac`. - [Release notes](https://github.com/paullouisageneau/libdatachannel/releases) - [Commits](paullouisageneau/libdatachannel@0e40aeb...a81daac) --- updated-dependencies: - dependency-name: third_party/libdatachannel/repo dependency-version: a81daaca4ca420be200ce9c9feb1cc76c8e3aa46 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…345) * Add mandatory feature support to the minimal device builder * Add new tests * Remove random print that snuck in * Fix feature error reporting * isort
…ilure event (#563) Co-authored-by: Restyled.io <[email protected]>
…#524) Co-authored-by: chirag-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Rohan Sahay <[email protected]>
This reverts commit dc2a1c6.
… into fix_history_1.4.2_merge
Co-authored-by: Michael Duggan <[email protected]>
…rge (#569) Co-authored-by: Mathieu Kardous <[email protected]>
Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Mathieu Kardous <[email protected]>
Co-authored-by: Mathieu Kardous <[email protected]>
…wer save APIs (#589) Co-authored-by: Copilot <[email protected]> Co-authored-by: Restyled.io <[email protected]>
rcasallas-silabs
force-pushed
the
draft/renode_ci
branch
from
6fffab4 to
1c51d4e
Compare
mkardous-silabs
changed the base branch from
release_2.5-1.4
to
release_2.6-1.4
mkardous-silabs
force-pushed
the
release_2.6-1.4
branch
from
6f26239 to
35a5a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PROTOTYPE: DO NOT MERGE!
Related issues
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines