Update CLA Validation Bot Triggers #651
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, daily PRs opened by
silabs-matter-ci-botto sync with latest CSA main trigger the CLA validation workflow. This behavior is not desired, as it will check for CSA users in the CLA validation database and send them emails as they have not signed.This happens because current implementation checks for
github.actor, which in this case would be the user for the latest commit that is pulled in by this PR (not either bot), causing this workflow to trigger.Updated the if condition to check for PRs opened by either bot, rather than
github.actor. This will ensure that any PR opened by either bot in this repo, regardless of the commits that are included, will not trigger the CLA Validation workflow.Testing
In
matter_extension_privaterepo, opened test PR from Copilot and included this user in if condition in CLA workflow (see Copilot PR and test CLA implementation here). With this test, the Copilot PR skipped the CLA Validation workflow step (see here) which is desired behavior.Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines