Skip to content

Conversation

@miduggan24
Copy link
Contributor

Summary

Currently, daily PRs opened by silabs-matter-ci-bot to sync with latest CSA main trigger the CLA validation workflow. This behavior is not desired, as it will check for CSA users in the CLA validation database and send them emails as they have not signed.

This happens because current implementation checks for github.actor, which in this case would be the user for the latest commit that is pulled in by this PR (not either bot), causing this workflow to trigger.

Updated the if condition to check for PRs opened by either bot, rather than github.actor. This will ensure that any PR opened by either bot in this repo, regardless of the commits that are included, will not trigger the CLA Validation workflow.

Testing

In matter_extension_private repo, opened test PR from Copilot and included this user in if condition in CLA workflow (see Copilot PR and test CLA implementation here). With this test, the Copilot PR skipped the CLA Validation workflow step (see here) which is desired behavior.

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • PR title is
    descriptive
  • Apply the
    “When in Rome…”
    rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: Pull Request Guidelines

@miduggan24 miduggan24 requested a review from a team September 26, 2025 20:49
Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that in the matter_build_action you were implementing a generic cla bot.
Should we hold off on this until we can reuse that workflow everywhere?

@miduggan24
Copy link
Contributor Author

I saw that in the matter_build_action you were implementing a generic cla bot. Should we hold off on this until we can reuse that workflow everywhere?

@mkardous-silabs That makes sense to me. I can work on that first then come back to this.

Would it be best to limit bot PRs across all repos, or is that specific to matter_sdk? I don't see the value in running the CLA check for bots if we are checking the creator of the PR now anyways.

@mkardous-silabs
Copy link
Contributor

I saw that in the matter_build_action you were implementing a generic cla bot. Should we hold off on this until we can reuse that workflow everywhere?

@mkardous-silabs That makes sense to me. I can work on that first then come back to this.

Would it be best to limit bot PRs across all repos, or is that specific to matter_sdk? I don't see the value in running the CLA check for bots if we are checking the creator of the PR now anyways.

@miduggan24 I agree that there is not much value of running the cla on bot prs as a whole

@miduggan24
Copy link
Contributor Author

I saw that in the matter_build_action you were implementing a generic cla bot. Should we hold off on this until we can reuse that workflow everywhere?

@mkardous-silabs That makes sense to me. I can work on that first then come back to this.
Would it be best to limit bot PRs across all repos, or is that specific to matter_sdk? I don't see the value in running the CLA check for bots if we are checking the creator of the PR now anyways.

@miduggan24 I agree that there is not much value of running the cla on bot prs as a whole

@mkardous-silabs Sounds good. Can likely implement this change in shared action then and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants