[SL-ONLY] Oven app commands implementation #693

arun-silabs · 2025-10-27T06:09:32Z

Summary

This PR adds logic to handle the commands in the oven-app over all the oven endpoints.
Below are the list of commands supported over each endpoint:
Endpoint 2 (TemperatureControlledCabinet) : set-temperature, change-to-mode
Endpoint 3 (CookTop) : off
Endpoint 4, Endpoint 5 (CookSurface) : off

Related issues

MATTER-5573

Testing

Tested all the commands with 917SoC and verified that the functionality is working as mentioned in the design (https://confluence.silabs.com/spaces/MATTER/pages/696870856/MDD-0022+-+Oven+and+RangeHood+app+design)

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

PR title is
descriptive
Apply the
“When in Rome…”
rule (coding style)
PR size is short
Try to avoid "squashing" and "force-update" in commit history
CI time didn't increase

See: Pull Request Guidelines

sabollim-silabs · 2025-10-28T06:50:42Z

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

+    /**
+     * @brief Set On/Off state for the CookSurface.
+     */
+    void SetOnOffState(bool state);


Set should return the status

modified as per suggestion

sabollim-silabs · 2025-10-28T06:52:09Z

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

     */
-    void HandleOffCommand();
+
+    bool GetOnOffState();


it should return status and get should fil the data in variable passed as arg

sabollim-silabs · 2025-10-28T06:52:56Z

examples/oven-app/oven-app-common/include/CookTopEndpoint.h

     * @brief Handle the "off" command for the cooktop.
     */
-    void HandleOffCommand();
+    void SetOnOffState(bool state);


Set should return the status

sabollim-silabs · 2025-10-28T06:53:10Z

examples/oven-app/oven-app-common/include/OvenEndpoint.h

    CHIP_ERROR GetModeValueByIndex(uint8_t modeIndex, uint8_t & value) override;
    CHIP_ERROR GetModeTagsByIndex(uint8_t modeIndex, DataModel::List<detail::Structs::ModeTagStruct::Type> & tags) override;

+    // Public helper to query support status without exposing internal tables


comment irrelevant

removed the comment

sabollim-silabs · 2025-10-28T06:57:49Z

examples/oven-app/oven-app-common/include/OvenEndpoint.h

    CHIP_ERROR GetModeTagsByIndex(uint8_t modeIndex, DataModel::List<detail::Structs::ModeTagStruct::Type> & tags) override;

+    // Public helper to query support status without exposing internal tables
+    static bool IsSupportedMode(uint8_t mode);


any specific reason for making this static

Initial skeleton code has the oven-modes as static variables, so made this function static to access those variables.
Now, since the oven-modes are modified to enum, we can make this function non-static. Made this change

sabollim-silabs · 2025-10-28T06:59:42Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp


 CHIP_ERROR CookSurfaceEndpoint::Init()
 {
+    bool state = false;


this can be removed, as this doesnt add functionaity

sabollim-silabs · 2025-10-28T07:00:08Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

 }

-void CookSurfaceEndpoint::HandleOffCommand()
+bool CookSurfaceEndpoint::GetOnOffState()


same as comments in .h

modified as per the suggestions

sabollim-silabs · 2025-10-28T07:00:18Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+    return state;
+}
+
+void CookSurfaceEndpoint::SetOnOffState(bool state)


same as comments in .h

sabollim-silabs · 2025-10-28T07:00:24Z

examples/oven-app/oven-app-common/src/CookTopEndpoint.cpp

 }

-void CookTopEndpoint::HandleOffCommand()
+void CookTopEndpoint::SetOnOffState(bool state)


same as comments in .h

sabollim-silabs · 2025-10-28T07:13:21Z

examples/oven-app/silabs/src/OvenManager.cpp

+}
+} // namespace
+
+void OvenManager::ProcessOvenModeChange(chip::EndpointId endpointId, uint8_t newMode,


some part of code can be leveraged into common code

Done, moved most of the code to common layer and kept only the mode-transition logic in OvenManager.

jmartinez-silabs · 2025-10-29T14:57:37Z

examples/oven-app/silabs/src/OvenManager.cpp

+    // Get CookTop On/Off value
+    // OnOffServer::Instance().getOnOffValue(1, &currentLedState);
+    // mCookTopState                 = currentLedState ? kState_OnCompleted : kState_OffCompleted;
+


if not needed, let's remove it

jmartinez-silabs · 2025-10-29T14:59:52Z

examples/oven-app/silabs/src/AppTask.cpp

+{
+    if (aActor == AppEvent::kEventType_CookTop)
+    {
+        bool lightOn = aAction == OvenManager::ON_ACTION;


lightOn should be renamed

removed this as the action_initiated and completed callbacks are suggested to be removed.

jmartinez-silabs · 2025-10-29T15:46:44Z

examples/oven-app/silabs/src/OvenManager.cpp

+        AppTask::GetAppTask().PostEvent(&event);
+    }
+
+    if (action_initiated && mActionInitiated_CB)
+    {
+        mActionInitiated_CB(aAction, aActor, aValue);
+    }
+
+    return action_initiated;


The whole PostEvent + ActionInitiated callback and then PostEvent calling ActionCompleted as no value for this app.
Nothing is really done in your ActuatorMovementHandler that necessitate a Queue event and then nothing is done either in the ActionCompleted except a print.

mSyncClusterToButtonAction is set to true/false over ActionInitiated and ActionCompleted but nothing is done with this variable.

I get that you copied this pattern from other sample apps but in this instance there is a whole lot of function and events to essentially do nothin except setting an object variable state and telling the LCD to update its screen.

This can all be simplified to 1 function or one posted Event

I have removed the PostEvent + ActionInitiated callback flow as suggested. I added logic just to post an event to AppTask which takes care of the required hardware action (LED and LCD update in our sample app).

jmartinez-silabs · 2025-10-29T15:48:29Z

examples/oven-app/silabs/src/OvenManager.cpp

+            bool cookSurfaceEndpoint2State;
+            mCookSurfaceEndpoint1.GetOnOffState(cookSurfaceEndpoint1State);
+            mCookSurfaceEndpoint2.GetOnOffState(cookSurfaceEndpoint2State);
+            // Check if both cooksurfaces are off. If yes, turn off the cooktop (call cooktop.TurnOffCookTop)


Is this defined by spec or a choice?

It is not defined in spec, we have added this in our application as a choice.

jmartinez-silabs · 2025-10-29T15:55:39Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+chip::Protocols::InteractionModel::Status CookSurfaceEndpoint::SetOnOffState(bool state)
+{
+    CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id;
+    auto status         = OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false);


Calling 'OnOffServer::Instance().setOnOffValue` must be called from the ChipTask context or with the ChipTask lock else it will cause and assert/chip die.

When called in OnOffAttributeChangeHandler which is called from MatterPostAttributeCallback, we are indeed in the ChipTaskl context. However, if this is called somewhere else then this might not be the case and it can lead to crashes.

If you keep it this way this function usage (an all the copied functionson the other endpoints) needs to be documented to explain this risk/limitation in the usage.

Same goes for the GetOnOffState

Like @jmartinez-silabs said please add a lock on the chip task before doing so.

I have added comments in the header file regarding the usage of this function.
I guess we do not need to add lock on chip-task in this place as the SetOnOffValue is being executed from chiptask only.

Copilot

Pull Request Overview

This PR implements command handling logic for an oven application across multiple endpoints as part of the [SL-ONLY] Oven app commands implementation. It adds support for set-temperature and change-to-mode commands on the TemperatureControlledCabinet endpoint (endpoint 2), and off commands for CookTop (endpoint 3) and CookSurface endpoints (endpoints 4 & 5).

Adds complete oven application structure with endpoint management and command handling
Implements temperature control with supported levels for cook surfaces and setpoint control for temperature controlled cabinet
Creates data model callbacks and attribute change handlers for coordinated state management across endpoints

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
examples/oven-app/silabs/src/OvenManager.cpp	Core manager implementing endpoint initialization and command handling coordination
examples/oven-app/silabs/src/DataModelCallbacks.cpp	Attribute change callback handlers for OnOff, TemperatureControl, and OvenMode clusters
examples/oven-app/silabs/src/AppTask.cpp	Main application task with oven manager initialization
examples/oven-app/silabs/src/AppSupportedTemperatureLevelsDelegate.cpp	Temperature levels delegate for cook surface endpoints
examples/oven-app/oven-app-common/src/OvenEndpoint.cpp	Oven mode delegate implementation with transition blocking logic
examples/oven-app/oven-app-common/src/CookTopEndpoint.cpp	CookTop endpoint OnOff state management
examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp	CookSurface endpoint OnOff state management
examples/oven-app/oven-app-common/oven-app.matter	Matter data model definition for oven application
examples/oven-app/silabs/include/*.h	Header files defining class interfaces and configuration
examples/oven-app/oven-app-common/include/*.h	Common header files for endpoint implementations
examples/oven-app/silabs/build_.gn	Build configuration files for WiFi and general builds
examples/oven-app/oven-app-common/BUILD.gn	Build configuration for common oven app components

examples/oven-app/silabs/src/OvenManager.cpp

examples/oven-app/oven-app-common/include/OvenEndpoint.h

examples/oven-app/silabs/src/AppSupportedTemperatureLevelsDelegate.cpp

jepenven-silabs · 2025-11-04T19:57:00Z

Regarding the folder structure we should really have the following :

examples
oven_app
src
include
data_model
third_party \ (if needed for gn support)
Since we don't plan on sharing this to CSA no need for "oven_common" or "silabs" subdirectory. 😄

jepenven-silabs

Stopping review for now as this seems to be a work in progress.

Please apply the comments, cleanup the logs, remove unused functions/methods when necessary.

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

jepenven-silabs · 2025-11-04T20:04:46Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+chip::Protocols::InteractionModel::Status CookSurfaceEndpoint::GetOnOffState(bool & state)
+{
+    auto status = OnOffServer::Instance().getOnOffValue(mEndpointId, &state);
+    VerifyOrReturnValue(status == Protocols::InteractionModel::Status::Success, status,


we could do without this verify or return and let the higher level handle the logging if necessary. Please remove.

jepenven-silabs · 2025-11-04T20:05:37Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+chip::Protocols::InteractionModel::Status CookSurfaceEndpoint::SetOnOffState(bool state)
+{
+    CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id;
+    auto status         = OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false);


Like @jmartinez-silabs said please add a lock on the chip task before doing so.

jepenven-silabs · 2025-11-04T20:05:57Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+{
+    CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id;
+    auto status         = OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false);
+    VerifyOrReturnValue(status == Protocols::InteractionModel::Status::Success, status,


Again since we are returning a status, please remove this check.

jepenven-silabs · 2025-11-04T20:06:18Z

examples/oven-app/oven-app-common/src/CookTopEndpoint.cpp


 CHIP_ERROR CookTopEndpoint::Init()
 {
    return CHIP_NO_ERROR;


Again please add a comment as why this function is needed.

This is a placeholder function similar to one in CookSurface, added a comment.

jepenven-silabs · 2025-11-04T20:06:51Z

examples/oven-app/oven-app-common/src/CookTopEndpoint.cpp

+{
+    CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id;
+    auto status         = OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false);
+    VerifyOrReturnValue(status == Protocols::InteractionModel::Status::Success, status,


Please remove this line as we are returning a status

jepenven-silabs · 2025-11-04T20:07:57Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

 using chip::Protocols::InteractionModel::Status;

 // Static member definitions
 const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsBake[1] = { { .value = to_underlying(ModeTag::kBake) } };


Please find a cleaner way to handle this.

done, simplified the tag-definitions.

jepenven-silabs · 2025-11-04T20:08:39Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

                                                                                            to_underlying(ModeTag::kProofing) } };

 const detail::Structs::ModeOptionStruct::Type OvenModeDelegate::skModeOptions[to_underlying(OvenModes::kModeCount)] = {
    { .label    = CharSpan::fromCharString("Bake"),


again this is unreadable 😢 , there must be a cleaner and more concise way to achieve the desired result.

simplified the declarations by adding this : using detail::Structs::ModeOptionStruct::Type

jepenven-silabs · 2025-11-04T20:09:35Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp


 CHIP_ERROR OvenModeDelegate::Init()
 {
    // No initialization required for OvenModeDelegate


Then why do we need this method ? please remove it since it's adding dead code which can cause code size bloats for no reason.

ModeBase::Instance is the base interface from where we extend the OvenModeDelegate class. Init function is declared in the ModeBase::Instance interface, so it should be defined in our OvenModeDelegate class.

jepenven-silabs · 2025-11-04T20:10:35Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

    return CHIP_NO_ERROR;
 }

 void OvenModeDelegate::HandleChangeToMode(uint8_t NewMode, ModeBase::Commands::ChangeToModeResponse::Type & response)


Didn't we have a mode enum somewhere in another header file ? is so we should use it instead of the generic uint8_t

HandleChangeToMode is a function given by the delegate. In the delegate, it has uint8_t as the parameter type.
For oven modes, we have added a mode enum instead of having the modes as some static constants.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

examples/oven-app/silabs/src/OvenManager.cpp

examples/oven-app/oven-app-common/include/CookTopEndpoint.h

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

examples/oven-app/oven-app-common/include/CookTopEndpoint.h

Co-authored-by: Jean-Francois Penven <[email protected]> Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

examples/oven-app/silabs/src/OvenManager.cpp

Copilot · 2025-11-05T13:34:13Z

examples/oven-app/silabs/include/OvenManager.h

+    static constexpr BlockedTransition kBlockedTransitions[3] = {
+        { chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeGrill),
+          chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeProofing) },
+        { chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeProofing),
+          chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeClean) },
+        { chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeClean),
+          chip::to_underlying(chip::app::Clusters::TemperatureControlledCabinet::OvenModeDelegate::OvenModes::kModeBake) },
+    };


The blocked transitions array is defined but lacks explanation of why these specific transitions are blocked. Consider adding a comment describing the rationale (e.g., safety concerns, mode incompatibilities) for blocking Grill→Proofing, Proofing→Clean, and Clean→Bake transitions.

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

Copilot

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Copilot · 2025-11-05T14:41:24Z

examples/oven-app/oven-app-common/include/CookTopEndpoint.h

+    chip::Protocols::InteractionModel::Status SetOnOffState(bool state);

 private:
    bool currentOnOffState = false;


The private member variable currentOnOffState appears to be unused since the implementation now relies on OnOffServer::Instance() to manage the on/off state. This field should be removed to avoid confusion and potential state synchronization issues.

Suggested change

bool currentOnOffState = false;

Copilot

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

examples/oven-app/silabs/include/OvenManager.h

jepenven-silabs · 2025-11-05T15:07:57Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

+const Type OvenModeDelegate::sModeTagsConvection[1] = { { .value = to_underlying(ModeTag::kConvection) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsGrill[1] = { { .value = to_underlying(ModeTag::kGrill) } };
+const Type OvenModeDelegate::sModeTagsGrill[1] = { { .value = to_underlying(ModeTag::kGrill) } };


why do we need an array of 1 ? What is this logic and why is this needed ?

This logic is for adding a unique tag to all the oven-modes.
those length‑1 arrays hold the single ModeTag value for each oven mode so we can give a DataModel::List view (which expects contiguous storage + a size) to the ModeOptionStruct entries.

jepenven-silabs · 2025-11-05T15:13:38Z

examples/oven-app/oven-app-common/src/CookSurfaceEndpoint.cpp

+chip::Protocols::InteractionModel::Status CookSurfaceEndpoint::SetOnOffState(bool state)
+{
+    CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id;
+    return OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false);


Shouldn't this be encased in a chipTaskLock ?

Not necessarily if it is called from ChipTask. I have added the function usage in header file (

matter_sdk/examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

Line 62 in 52cb237

* Note: This helper writes the OnOff attribute to the CHIP attribute storage and

)
ScheduleWork or ChipTaskLock should only be used if this function is called from AppTask

jepenven-silabs · 2025-11-05T15:17:47Z

examples/oven-app/silabs/include/AppTask.h


 #include "AppEvent.h"
 #include "BaseApplication.h"
+#include "OvenManager.h"


why is this needed here ?

It is not needed, removed it.

jepenven-silabs · 2025-11-05T15:20:22Z

examples/oven-app/silabs/src/DataModelCallbacks.cpp

+                        ChipLogValueMEI(attributeId), type, *value, size);
+        break;
+    case app::Clusters::OnOff::Id:
+        ChipLogProgress(Zcl, "OnOff cluster ID: " ChipLogFormatMEI " Type: %u Value: %u, length %u", ChipLogValueMEI(attributeId),


All of these should be ChipLogDetails and not ChipLogProgress

modified as suggested

jepenven-silabs · 2025-11-05T15:21:02Z

examples/oven-app/silabs/include/OvenManager.h

    chip::app::Clusters::AppSupportedTemperatureLevelsDelegate mTemperatureControlDelegate;

+    State_t mCookTopState;
+    State_t mCookSurfaceState1;


Why do we need 2 SurfaceState ?

customer requirements mentioned 2 surfaces . so we added 2 surfaces

A cook-top can contain multiple cook-surfaces
In our app, we have 2 cook surfaces (as per the requirements doc that we received). . To store the state of these 2 cook-surfaces separately, i have used 2 state variables. There is a possibility that one cook-surface is "On" and another cook-surface is "Off"

jepenven-silabs

a couple of things left to polish out

Copilot

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Copilot · 2025-11-05T16:31:41Z

examples/oven-app/oven-app-common/src/OvenEndpoint.cpp

+const Type OvenModeDelegate::sModeTagsBake[1] = { { .value = to_underlying(ModeTag::kBake) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsConvection[1] = { { .value = to_underlying(
-                                                                                              ModeTag::kConvection) } };
+const Type OvenModeDelegate::sModeTagsConvection[1] = { { .value = to_underlying(ModeTag::kConvection) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsGrill[1] = { { .value = to_underlying(ModeTag::kGrill) } };
+const Type OvenModeDelegate::sModeTagsGrill[1] = { { .value = to_underlying(ModeTag::kGrill) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsRoast[1] = { { .value = to_underlying(ModeTag::kRoast) } };
+const Type OvenModeDelegate::sModeTagsRoast[1] = { { .value = to_underlying(ModeTag::kRoast) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsClean[1] = { { .value = to_underlying(ModeTag::kClean) } };
+const Type OvenModeDelegate::sModeTagsClean[1] = { { .value = to_underlying(ModeTag::kClean) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsConvectionBake[1] = { { .value = to_underlying(
-                                                                                                  ModeTag::kConvectionBake) } };
+const Type OvenModeDelegate::sModeTagsConvectionBake[1] = { { .value = to_underlying(ModeTag::kConvectionBake) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsConvectionRoast[1] = { { .value = to_underlying(
-                                                                                                   ModeTag::kConvectionRoast) } };
+const Type OvenModeDelegate::sModeTagsConvectionRoast[1] = { { .value = to_underlying(ModeTag::kConvectionRoast) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsWarming[1] = { { .value =
-                                                                                           to_underlying(ModeTag::kWarming) } };
+const Type OvenModeDelegate::sModeTagsWarming[1] = { { .value = to_underlying(ModeTag::kWarming) } };

-const detail::Structs::ModeTagStruct::Type OvenModeDelegate::sModeTagsProofing[1] = { { .value =
-                                                                                            to_underlying(ModeTag::kProofing) } };
+const Type OvenModeDelegate::sModeTagsProofing[1] = { { .value = to_underlying(ModeTag::kProofing) } };


[nitpick] The typedef alias 'Type' for 'detail::Structs::ModeTagStruct::Type' obscures the actual type being used in these static member definitions. While it reduces line length, it makes the code less self-documenting. Consider using the full type name or a more descriptive alias that indicates it's a ModeTag struct type.

Copilot · 2025-11-05T16:31:41Z

examples/oven-app/silabs/src/OvenManager.cpp

+        mCookSurfaceEndpoint1.GetOnOffState(cookSurfaceEndpoint1State);
+        mCookSurfaceEndpoint2.GetOnOffState(cookSurfaceEndpoint2State);
+        // Turn off CookTop if both the CookSurfaces are off.
+        if (!cookSurfaceEndpoint1State && !cookSurfaceEndpoint2State)
+        {
+            mCookTopEndpoint.SetOnOffState(false);
+            mCookTopState = kCookTopState_Off;
+        }


The return value of GetOnOffState() is not checked. If GetOnOffState() fails (returns error Status), the variables cookSurfaceEndpoint1State and cookSurfaceEndpoint2State will contain uninitialized values, potentially causing incorrect state decisions on line 168. Check the Status return value before using these variables.

Suggested change

mCookSurfaceEndpoint1.GetOnOffState(cookSurfaceEndpoint1State);

mCookSurfaceEndpoint2.GetOnOffState(cookSurfaceEndpoint2State);

// Turn off CookTop if both the CookSurfaces are off.

if (!cookSurfaceEndpoint1State && !cookSurfaceEndpoint2State)

{

mCookTopEndpoint.SetOnOffState(false);

mCookTopState = kCookTopState_Off;

}

Status status1 = mCookSurfaceEndpoint1.GetOnOffState(cookSurfaceEndpoint1State);

Status status2 = mCookSurfaceEndpoint2.GetOnOffState(cookSurfaceEndpoint2State);

// Turn off CookTop if both the CookSurfaces are off.

if (status1 == Status::Success && status2 == Status::Success)

{

if (!cookSurfaceEndpoint1State && !cookSurfaceEndpoint2State)

{

mCookTopEndpoint.SetOnOffState(false);

mCookTopState = kCookTopState_Off;

}

}

else

{

ChipLogError(AppServer, "Failed to get CookSurface OnOff state (status1=%d, status2=%d)", static_cast<int>(status1), static_cast<int>(status2));

}

Copilot · 2025-11-05T16:31:42Z

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h

+     *
+     * @return Returns Status::Success on success, or an error code on failure.
+     */
+


[nitpick] Extra blank line between documentation and function declaration. Remove the blank line on line 55 to maintain consistency with standard documentation formatting practices.

Suggested change

arun-silabs force-pushed the feature/oven_app_commands_implementation branch from af4ef43 to 83372e0 Compare October 28, 2025 09:33

sabollim-silabs requested changes Oct 28, 2025

View reviewed changes

arun-silabs marked this pull request as ready for review October 28, 2025 15:54

arun-silabs requested a review from a team as a code owner October 28, 2025 15:54

arun-silabs changed the title ~~[DRAFT] [SL-ONLY] Oven app commands implementation~~ [SL-ONLY] Oven app commands implementation Oct 28, 2025

arun-silabs force-pushed the feature/oven_app_commands_implementation branch 2 times, most recently from 2014ada to 43caebd Compare October 29, 2025 09:36

arun-silabs requested a review from sabollim-silabs October 29, 2025 13:50

jmartinez-silabs requested changes Oct 29, 2025

View reviewed changes

Base automatically changed from feature/oven_app_skeleton to main October 29, 2025 16:02

Copilot AI review requested due to automatic review settings November 4, 2025 10:21

Copilot AI reviewed Nov 4, 2025

View reviewed changes

examples/oven-app/silabs/src/OvenManager.cpp Outdated Show resolved Hide resolved

examples/oven-app/oven-app-common/include/OvenEndpoint.h Outdated Show resolved Hide resolved

examples/oven-app/silabs/src/AppSupportedTemperatureLevelsDelegate.cpp Outdated Show resolved Hide resolved

arun-silabs force-pushed the feature/oven_app_commands_implementation branch from daebfbd to 2434980 Compare November 4, 2025 10:34

jepenven-silabs requested changes Nov 4, 2025

View reviewed changes

arun-silabs and others added 15 commits November 5, 2025 14:34

Oven App skeleton code with all endpoint initialisations

f24e3f0

Restyled by whitespace

90e0388

Restyled by clang-format

65a5c48

Address copilot review

1a8dd8d

Restyled by clang-format

8c86d55

Apply suggestions from code review

204d3a1

Co-authored-by: Copilot <[email protected]>

Apply suggestions from code review

ec3943e

Co-authored-by: Copilot <[email protected]>

Address copilot review comments

2b9505f

Address review comments and modify the file structures accordingly

03aa29e

Restyled by gn

ebf324e

Add required TODOs and optimize the skeleton code

6d73e62

Restyled by whitespace

9f63524

Restyled by clang-format

d5f86e9

Cleanup comments

00952f3

Address review comments

df13ff4

Rebase with main branch

232fe4f

Copilot AI review requested due to automatic review settings November 5, 2025 13:21

arun-silabs force-pushed the feature/oven_app_commands_implementation branch from 2434980 to 232fe4f Compare November 5, 2025 13:21

silabs-matter-ci-bot bot added the sl-only This TAG indicates that this commit is a silabs-specific commit that cannot be upstreamed to CSA. label Nov 5, 2025

Copilot AI reviewed Nov 5, 2025

View reviewed changes

examples/oven-app/silabs/src/OvenManager.cpp Outdated Show resolved Hide resolved

examples/oven-app/oven-app-common/include/CookTopEndpoint.h Show resolved Hide resolved

examples/oven-app/oven-app-common/include/CookSurfaceEndpoint.h Show resolved Hide resolved

restyled-commits added 2 commits November 5, 2025 18:55

Restyled by whitespace

50bfb9c

Restyled by clang-format

efceeac

arun-silabs commented Nov 5, 2025

View reviewed changes

examples/oven-app/oven-app-common/include/CookTopEndpoint.h Outdated Show resolved Hide resolved

Apply suggestions from code review

d3cb6fa

Co-authored-by: Jean-Francois Penven <[email protected]> Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 5, 2025 13:33

Copilot AI reviewed Nov 5, 2025

View reviewed changes

arun-silabs added 2 commits November 5, 2025 19:51

Address review comments

ba72490

Fix zap issue

f68c4e2

Copilot AI review requested due to automatic review settings November 5, 2025 14:40

Copilot AI reviewed Nov 5, 2025

View reviewed changes

restyled-commits and others added 2 commits November 5, 2025 20:13

Restyled by clang-format

fbc02c4

Remove redundant cook surface init

52cb237

arun-silabs requested review from Copilot and jepenven-silabs November 5, 2025 14:56

Copilot AI reviewed Nov 5, 2025

View reviewed changes

examples/oven-app/silabs/include/OvenManager.h Show resolved Hide resolved

jepenven-silabs reviewed Nov 5, 2025

View reviewed changes

arun-silabs and others added 2 commits November 5, 2025 21:56

Address review comments

1baad61

Restyled by clang-format

6d426f9

Copilot AI review requested due to automatic review settings November 5, 2025 16:30

Copilot AI reviewed Nov 5, 2025

View reviewed changes

[SL-ONLY] Oven app commands implementation #693

Are you sure you want to change the base?

[SL-ONLY] Oven app commands implementation #693

Uh oh!

Conversation

arun-silabs commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related issues

Testing

Readability checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

arun-silabs commented Oct 27, 2025 •

edited

Loading