[SL-ONLY] Feature/rangehood app #698
Conversation
silabs-matter-ci-bot
bot
added
the
sl-only
| @@ -0,0 +1,29 @@ | |||
| # Copyright (c) 2025 Project CHIP Authors | |||
There was a problem hiding this comment.
This file should be deleted.
| static void ActionInitiated(RangeHoodManager::Action_t aAction, int32_t aActor, uint8_t * value); | ||
| static void ActionCompleted(RangeHoodManager::Action_t aAction); | ||
|
|
||
| static void LightActionEventHandler(AppEvent * aEvent); |
There was a problem hiding this comment.
Looks like this is not being used.
There was a problem hiding this comment.
Button event handler added for Fancontrol so this is not required so removed, thanks for the comment @chirag-silabs
| * @param aEvent button event being processed | ||
| */ | ||
| static void ButtonHandler(AppEvent * aEvent); | ||
| // Work item executed on CHIP stack thread to toggle fan mode safely |
There was a problem hiding this comment.
Add comments for the API
There was a problem hiding this comment.
Added comments and renamed it to FanControlButtonHandler as BTN1 is used for Fan control ON/OFF.
| uint8_t percentCurrent; | ||
| uint8_t speedCurrent; | ||
|
|
||
| // Fan Mode Limits |
There was a problem hiding this comment.
Are these being used anywhere?
| : FanControl::Delegate(aEndpoint), mEndpoint(aEndpoint) {} | ||
|
|
||
| protected: | ||
| EndpointId mEndpoint = 0; |
There was a problem hiding this comment.
by default endpoint should be invalid endpoint
| */ | ||
| Status HandleStep(StepDirectionEnum aDirection, bool aWrap, bool aLowestOff) override; | ||
|
|
||
| FanDelegate(EndpointId aEndpoint) |
There was a problem hiding this comment.
ideally constructor should be before other functions
| CHIP_ERROR LightEndpoint::Init() | ||
| { | ||
| bool state = false; | ||
| OnOffServer::Instance().getOnOffValue(mEndpointId, &state); |
There was a problem hiding this comment.
should call with the ChipTask lock
| bool LightEndpoint::GetOnOffState() | ||
| { | ||
| bool state = false; | ||
| OnOffServer::Instance().getOnOffValue(mEndpointId, &state); |
There was a problem hiding this comment.
should call with the ChipTask lock
| void LightEndpoint::SetOnOffState(bool state) | ||
| { | ||
| CommandId commandId = state ? OnOff::Commands::On::Id : OnOff::Commands::Off::Id; | ||
| auto status = OnOffServer::Instance().setOnOffValue(mEndpointId, commandId, false); |
There was a problem hiding this comment.
should call with the ChipTask lock
| @@ -0,0 +1,29 @@ | |||
| # Copyright (c) 2025 Project CHIP Authors | |||
There was a problem hiding this comment.
Duplicate file to be removed
| import("${chip_root}/src/platform/silabs/wifi/args.gni") | ||
|
|
||
| sl_enable_test_event_trigger = false | ||
| chip_enable_ota_requestor = false |
|
|
||
| #define APP_TASK_NAME "RangeHood" | ||
|
|
||
| #define BLE_DEV_NAME "SiLabs-RangeHood" |
There was a problem hiding this comment.
we can use Silabs-$APP_TASK_NAME
There was a problem hiding this comment.
Done as per suggestion
| #endif // SL_LCDCTRL_MUX | ||
| } | ||
|
|
||
| void RangeHoodUI::DrawFont(GLIB_Context_t * glibContext, uint8_t initial_x, uint8_t initial_y, uint8_t width, uint8_t * data, |
There was a problem hiding this comment.
we can use the font avialable in GLIB directly, these are written for thermostat for a specific purpose.
There was a problem hiding this comment.
This can be removed as did not use.
Summary
Related issues
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines