Sync csa-v1.5-branch branch with release_2.8-1.5#759
Open
silabs-matter-ci-bot[bot] wants to merge 44 commits intorelease_2.8-1.5from
Open
Sync csa-v1.5-branch branch with release_2.8-1.5#759silabs-matter-ci-bot[bot] wants to merge 44 commits intorelease_2.8-1.5from
silabs-matter-ci-bot[bot] wants to merge 44 commits intorelease_2.8-1.5from
Conversation
* Allocate PacketBuffer with kMaxAllocSize for lwIP PBUF_RAM (#41974) * Allocate PacketBuffer with kMaxAllocSize if lwIP PBUF_RAM is enabled * Add more comments (cherry picked from commit 013e1bb) * [ESP32] Enable TCP on ESP32 platform (#35343) * enable tcp on esp32 platform * Fix max tcp buffer for esp32 platform * Removed TCPEndPointImplLwIP from platform * Removed TCPEndPointImplLwIP from platform * Added config for overriding platform tcp buffer size * Use chainedBuffer * Add config option to enable tcp transport * Add config for lwIP PBUF_RAM --------- Co-authored-by: chendejin <chendejin@espressif.com> (cherry picked from commit 10a22c9) --------- Co-authored-by: Dejin <45139296+DejinChen@users.noreply.github.com> Co-authored-by: chendejin <chendejin@espressif.com>
silabs-matter-ci-bot
bot
added
changing-git-submodules-on-purpose
sl-require-admin-action
Contributor
|
The check for |
Junior Martinez (jmartinez-silabs)
approved these changes
Dec 9, 2025
* [NXP] Allow extra customization of default lock app (#41843) Allow selecting extra gatt db header without depending on other config options. Allow deriving the base lock app AppTask and DeviceCallbacks classes. Signed-off-by: Marius Preda <marius.preda@nxp.com> * [NXP][platform][common] Avoid using static state variables in OTA firmware processor (#41944) Using function local static state variables such as "ulCrtAddr" and "ulEraseLen" in the OTAFirmwareProcessor::ProcessInternal method causes issues when OTA transfers are interrupted and then resumed because the function local variables cannot be accessed (and reset) by other class methods (such as OTAFirmwareProcessor::Clear or OTAFirmwareProcessor::AbortAction). The use of function local state variables was dropped and the SDK wireless framework OTA support layer is now in charge of managing block addresses and erases. Reviewed-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [NXP][doc][mcxw7x] Update MCXW7x platforms documentation (#41910) * [nxp][doc][examples][mcxw71] Restructure platform documentation Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [nxp][doc][examples][mcxw72] Restructure platform documentation Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [nxp][cmake][platform][mcxw7x] Remove unused ICD build options Removed the build options o CONFIG_CHIP_ICD_IDLE_MODE_INTERVAL_MS o CONFIG_CHIP_ICD_ACTIVE_MODE_INTERVAL_MS which don't seem to be used anywhere. They were most likely leftovers after replacement with o CHIP_ICD_IDLE_MODE_DURATION o CHIP_ICD_ACTIVE_MODE_DURATION Signed-off-by: Marian Chereji <marian.chereji@nxp.com> --------- Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [NXP] Fix DnssdImplBr handling of SRP cache resolve (#41848) * [NXP] Fix DnssdImplBr handling of SRP cache resolve This commit fixes the case where a service query is resolved directly from the SRP cache on a Border Router. In this case there is no need to add the context to the list and start the OT mMDNS client. Signed-off-by: Marius Preda <marius.preda@nxp.com> * Restyled by clang-format * [NXP] Added comment to HandleResolveCleanup Signed-off-by: Marius Preda <marius.preda@nxp.com> * Restyled by whitespace --------- Signed-off-by: Marius Preda <marius.preda@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> * [nxp][cmake][platform][mcxw7x] Increase LIT ICD idle mode duration to one hour (#41993) For Long Idle Time ICDs the idle mode duration may be several hours or even longer. Reviewed-by: Marian Chereji <marian.chereji@nxp.com> Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [NXP] Fix read last-networking-status and read last-network-id issue for ethernet and wifi (#42031) * [NXP][wifi] Fix read last-networking-status and read last-network-id issue Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * [NXP][ethernet] Fix read last-networking-status and read last-network-id issue Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * [NXP] fix PR comment Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> * [NXP][wifi-otbr] fix TC-CGEN-2.2 issue due to multiple mdns advertising updates in short time (#42032) Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * [NXP] Fix TC-CGEN-2.4 and TC-CGEN-2.2 issue due to unnecessary wifi connection during revert config (#42064) Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * [NXP] Deprecating GN build support for NXP MCUs, retaining only minimal application support for the MCXW72 and RW61X platforms (#41060) * [NXP] Deprecating GN build support for NXP MCUs, retaining only minimal application support for the MCXW72 and RW61X platforms Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> * Restyling + fix readme bad references Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> * Removing cmake option for nxp build from all_targets_linux_x64.txt Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> * Updating documentation to remove cmake arg when build NXP freeRTOS example using build_example.py script Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> --------- Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> * [NXP] Fix BootReason for successful OTA (#41957) * [nxp][platform][common] Add App nvm keys to NXPConfig * Add App keys to be used for custom application nvm values set at runtime. * Add App OTA done key. * Update ValidConfigKey to account for new keys. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][platform][mcxw71] Add App nvm keys to K32W1Config * Add App keys to be used for custom application nvm values set at runtime. * Add App OTA done key. * Update ValidConfigKey to account for new keys. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][platform][mcxw7x] Update DetermineBootReason for successful OTA * Add read/write ota done nvm key in order to set kSoftwareUpdateCompleted boot reason. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by clang-format * [nxp][platform][mcxw71] Resolve conversations * Added more specific messages * Don't return error when read doesn't find key * Return error when failing to write Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][platform][mcxw71] Minimize usage of err in ConfigurationManagerImpl Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by clang-format --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> * [NXP] allow user to connect devices to open network (#42138) * [NXP] allow user to connect devices to open network Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Restyled by whitespace * Restyled by clang-format * [NXP] Fix PR comment Signed-off-by: Martin Girardot <martin.girardot@nxp.com> --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> * [NXP][example_common] Adding a dedicated KCONFIG option to register a simple test event trigger delegate (#42133) * [NXP][example_common] Adding a dedicated KCONFIG option to register a simple test event trigger delegate Signed-off-by: Oliver Fan <oliver.fan@nxp.com> * Update examples/platform/nxp/common/app_task/source/AppTaskBase.cpp Co-authored-by: Gatien Chapon <43855183+chapongatien@users.noreply.github.com> --------- Signed-off-by: Oliver Fan <oliver.fan@nxp.com> Co-authored-by: Gatien Chapon <43855183+chapongatien@users.noreply.github.com> * psa: fix buffer overflow (#42015) Signed-off-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com> * [Zephyr][platform][config] Update the existing Zephyr platform adaptation layer to make it reusable across multiple Zephyr-based platforms (#42198) * [Zephyr][platform] Update the generic Zephyr platform adaptation layer to be reusable by other zephyr platforms * Adding wifi to the BUILD.gn file to support building matter-over-wifi * Adding support of wifi in the ConnectivityManagerImpl * Adding DeviceInstanceInfoProviderImpl * Adding CHIP macro config mapping with Kconfig to ease platform overrides Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * [Zephyr][platform][config] Adding Kconfig definitions to the generic config/zephyr/Kconfig * Kconfig added to the generic layer, to allow platforms to reuse the src/platform/Zephyr and override the CHIP configs easily per platform * CONFIG_CHIP_LOG_SIZE_OPTIMIZATION moved from the platform layer definition to the generic zephyr Kconfig, to allow its use in src/platform/Zephyr, and reduce duplicatio * note that the default can still be overridden per platform Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * [Zephyr][platform][config] Adding Kconfig to configure the chip task priority, stack sze and event queue size + Adding Kconfig for MRP local retry intervals (active & idle) Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * Update src/platform/Zephyr/DeviceInstanceInfoProviderImpl.h line ending to support restyle patch Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io> --------- Signed-off-by: Marius Preda <marius.preda@nxp.com> Signed-off-by: Marian Chereji <marian.chereji@nxp.com> Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Martin Girardot <martin.girardot@nxp.com> Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> Signed-off-by: Oliver Fan <oliver.fan@nxp.com> Signed-off-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com> Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Co-authored-by: Marius Preda <marius.preda@nxp.com> Co-authored-by: Marian CHEREJI <122872376+marian-chereji-nxp@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Martin Girardot <165289184+Martin-NXP@users.noreply.github.com> Co-authored-by: andrei-menzopol <96489227+andrei-menzopol@users.noreply.github.com> Co-authored-by: Oliver FAN <156269022+OliverFan1@users.noreply.github.com> Co-authored-by: doru91 <doru-cristian.gucea@nxp.com> Co-authored-by: dinabenamar <108664279+dinabenamar@users.noreply.github.com>
* esp32: fix ICD configuration options * Update config/esp32/components/chip/Kconfig * gemini review changes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sid or password (#42320) (#42386) * esp32: fix issues for network commissioning test cases of incorrect ssid or password * review changes * call esp_wifi_connect() anyway * Restyled by clang-format * fix some potential no-def warnings --------- Co-authored-by: Restyled.io <commits@restyled.io>
Junior Martinez (jmartinez-silabs)
approved these changes
Dec 16, 2025
sarthak shaha (Sarthak-Shaha)
approved these changes
Dec 16, 2025
silabs-matter-ci-bot
bot
force-pushed
the
automation/update_release_2.8-1.5
branch
from
18e6ab7 to
c2ad2a5
Compare
…450)
* [Zephyr][platform] Adding Wi-Fi Network Diagnostics for Zephyr platform (#42283)
* [Zephyr][platform] Adding Wi-Fi Diagnostic Logs for Zephyr platform
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [Zephyr][platform] Fix issues where the output parameter is assigned a value from a structure that may be uninitialized if the function to populate it fails
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Restyled by clang-format
* [Zephyr][platform] Rework the architecture of the DiagnosticDataProviderImpl.h/cpp
* Keep DiagnosticDataProviderImpl.h/cpp base class generic
* Add a subclass specific to Wi-Fi network diagnostics, to avoid multiple conditions (#ifdef) in the base class file
* This change improves readability, separation of concerns and better maintainability
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Restyled by whitespace
* Restyled by clang-format
* [Zephyr][platform] Fix typo in the commend in BUILD.gn file
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Update src/platform/Zephyr/wifi/DiagnosticDataProviderImplWiFi.cpp
Co-authored-by: Sergio Soares <sergiosoares@google.com>
* [Zephyr][platform] Switch back to using CHIP_DEVICE_CONFIG_ENABLE_WIFI macro in .cpp file
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Sergio Soares <sergiosoares@google.com>
* [NXP] Upadte NXP freertos SDK version to 25.09.00 (#42285)
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [Zephyr][platform] Fix the subclass prefix in src/platform/Zephyr/wifi/DiagnosticDataProviderImplWiFi.cpp (#42341)
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP] Fixing MCXW71/72 build due to ChipError nodiscard addition (#42350)
* [NXP] Fixing MCXW71/72 build due to ChipError nodiscard addition when manufactory flow mode is supported
+ Adding ota and factory data support in github workflow
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
* Restyled
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
* Updating correct target path + adding ota in W71 github build
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
---------
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
* [NXP] upstream SDK 25.09 support (#42337)
* [NXP][examples][common] Update BR related code
Updated name of BR related variables to reflect
current changes in ot-nxp.
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* [NXP][border-router][rw61x] Updates for OT commit
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* [NXP][border-router][rt1170] Updates for OT commit
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* [NXP][border-router][rt1060] Updates for OT commit
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* [NXP][docs][RT] Updating OTA readme to document how to sign images with ECDSA algorithm
* Starting from MCUboot version 2.2, the default signature algorithm has changed to ECDSA-P256.
* Matter images are now signed using ECDSA by default.
* To ensure compatibility with older MCUboot versions (prior to 2.2), we also provide RSA-signed images named app_SIGNED_RSA.bin.
* These RSA-signed images should only be used with MCUboot builds that have RSA support enabled, which was the default behavior in versions before 2.2.
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP] update submodule for NXP SDK 25.09 support
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* Restyled by gn
* [NXP] resolve PR comment
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* Restyled by prettier-markdown
---------
Signed-off-by: Marius Preda <marius.preda@nxp.com>
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Co-authored-by: Marius Preda <marius.preda@nxp.com>
Co-authored-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
* [Zephyr][platform] Adding OTA Software Update support in the generic Zephyr platform layer (#42340)
* [Zephyr][platform] Adding OTA support in src/platform/Zephyr platform layer
* Added OTAImageProcessorImpl files to support OTA
* Moved OTA Kconfig to the generic config/zephyr/Kconfig file
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [Zephyr][platform] Fix nodiscard ChipError warning with TEMPORARY_RETURN_IGNORED
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Restyled by clang-format
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
* [NXP][doc] Fix download location for blhost (#42410)
The Bootloader Host Application tool (blhost) is no longer included
in the recent versions of the NXP LinkServer. Instead it can be
downloaded as a standalone tool from the MCU Bootloader downloads
page.
Reviewed-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com>
Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
* [NXP][platform][zephyr] Move Factory Data Provider files to be added on application level (#42403)
* [NXP][platform][zephyr] Adding factory data files on application level after migration to generic Zephyr platform layer
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][zephyr] Remove unnecessary includes from the application CMakelists.txt
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][zephyr] Remove the unnecessary include paths from application cmake files
* The includes are not required because the CHIP module already exposes all necessary includes.
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][zephyr] Migration from src/platform/nxp/zephyr to src/platform/Zephyr platform layer (#42391)
* [NXP][platform][zephyr] Migrate from src/platform/nxp/zephyr to src/platform/Zephyr
* Removing nxp_zephyr from gn* files
* Removing unused files from nxp/zephyr after migrating to generic Zephyr platform layer
* Update paths in application files after migration to generic Zephyr platform layer
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][zephyr] Adding factory data files on application level after migration to generic Zephyr platform layer
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Restyled by gn
* [NXP][platform][zephyr] Remove unnecessary includes from the application CMakelists.txt
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* Revert "[NXP][platform][zephyr] Remove unnecessary includes from the application CMakelists.txt"
This reverts commit 7551eb52cc940b3b0e2cbf49505afd85efcce9a7.
* Revert "[NXP][platform][zephyr] Adding factory data files on application level after migration to generic Zephyr platform layer"
This reverts commit 349a9a7e0acc02e40829933b15050d2f9e08e1d7.
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
* [NXP] update NXP docker images version used by github workflow
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* Revert "[NXP] Upadte NXP freertos SDK version to 25.09.00 (#42285)"
This reverts commit 869a73d6fa2b114a01fba9cdc8bc944669302420.
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
Signed-off-by: Marius Preda <marius.preda@nxp.com>
Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Sergio Soares <sergiosoares@google.com>
Co-authored-by: Martin Girardot <165289184+Martin-NXP@users.noreply.github.com>
Co-authored-by: Gatien Chapon <43855183+chapongatien@users.noreply.github.com>
Co-authored-by: Marius Preda <marius.preda@nxp.com>
Co-authored-by: Marian CHEREJI <122872376+marian-chereji-nxp@users.noreply.github.com>
Co-authored-by: Martin Girardot <martin.girardot@nxp.com>
…for WebRTC Requester Cluster (#42572) * [WebRTCR] Enable controller to manage multiple cameras (#41966) * [WebRTCR] Enable controller to manage multiple cameras * Address review comments * Explicitly initialize testSession.fabricIndex * [CodeDrivenClusters] Use UpperCamelCaseCluster naming for webrtc-transport-requestor-server (#42183) * Rename files to use UpperCamelCaseCluster/Logic for webrtc-transport-requestor-server * Fix include paths for webrtc-transport-requestor-server * Remove unit test for delegate interface (#42251) Co-authored-by: Andrei Litvin <andy314@gmail.com> * Rename WebRTCTransportRequestorServer to WebRTCTransportRequestorCluster (#42369) * Fix compile errors --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
…ace (#42571) * nodiscard ChipError Batch #5: clusters app code (#41863) * Batch #5 nodiscard errors: clusters app code * Fix CI & missed cleanup * Missed cleanup * Clang tidy * nodiscard ChipError Batch #2: example apps A-F (#41860) * Batch #2 nodiscard errors: example apps A-F * Fix clang tidy * [CodeDrivenClusters] Use UpperCamelCaseCluster naming for push-av-stream-transport-server (#42177) * Rename files to use UpperCamelCaseCluster/Logic for push-av-stream-transport-server * Fix include paths for push-av-stream-transport-server * Restyle. * Update scripts/tools/check_includes_config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Camera] Migrate WebRTC Provider Cluster to Server Cluster Interface (#42067) * [Camera] Migrate WebRTC Provider Cluster to Server Cluster Interface * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-cluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Remove un-used variables * Name things UpperCamelCaseCluster for code driven clusters * Update src/app/clusters/webrtc-transport-provider-server/tests/TestWebRTCTransportProviderCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> * Move CodegenIntegration to app specific build file (#42443) * Fix compile errors * Restyled by clang-format * Mount the root directory in the job, we should be able to gain a few GB of space. --------- Co-authored-by: Marcos B <15697303+gmarcosb@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
…(#42651) - ESP32 has its own clones for mbedtls, FreeRTOS-Kernel, lwip and it uses it sources it from esp-idf sdk. So don't clone it into third_party directory. - ESP32 platform does not require boringssl either. - Also, libtrustymatter is specific to NXP platform, so tagged it with platform nxp. Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
…sending a SIGTERM before signal handler is setup (#41688) (#42720) * TestSystemCommands: Delay between factory resets to prevent sending a SIGTERM before signal handler is setup * Add a new log message and watch for it instead of simply delaying * Restyled by whitespace * Restyled by clang-format * Test Darwin YAML breakage * Increase timeout * Fix timeout parameter name, more debug * Commissioning timeout should not have been replaced * debug CapturedLogContains * Waiting for 'Start event loop' won't work as App.start() already waits for 'mDNS service published:' which happens in the event loop * Make application up detection more robust by checking both mDNS advertisement and event loop start * Remove debug spam. Mark symptom log messages as such in SDK source code. Properly format exception strings. * Restore workflow files deleted by mistake * Explain improved application startup detection logic * Restyled by clang-format * Restyled by autopep8 * Improve readability, fix exception string formatting * Implement post-review changes - add type hints, use explicit arguments instead of *args and **kwargs - make search strategy more efficient, improve readability * Restyled by isort * Update test_definition.py Force lists, fix off-by-one * Post-review changes: - use self.process and self.outpipe in chiptest.App.__WaitFor - use 'marker' instead of 'symptom' * Restyled by clang-format * Restyled by ruff * minimalmdns: symptom -> marker * Restyled by isort * Leftover symptom -> marker * Post-review fixes --------- Signed-off-by: Maciej Grela <m.grela@samsung.com> Co-authored-by: Maciej Grela <m.grela@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
…2395) (#42662) * Fix missing report generation for PushAV and TLS clusters when Commands change attributes (#41837) * [PushAV] Add call to report generation on SetTransportStatus and ModifyPushTransport. * [TLSCert and TLSClient Management] Add attribute change reporting when commands update the corresponding list attributes. * [TLSCLIENT] Initial PR for conversion to Code Driven - Rename of cluster and associated classes (#42377) * [TLS-Client] Migrate TLS Client Management Cluster to code-driven (#42395) * [TLS-Client] Migrate TLS Client Management Cluster to code-driven * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix build issue * Remove unused vabrible * Fix warnings * Fix clang-tidy checker warning * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Fix compile error * Address copilot comments * Init TLS Client Management Cluster * Update examples/all-clusters-app/all-clusters-common/src/tls-client-management-instance.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Mark TLS client as code driven * Add missing stubs * Re-run codegen * Address review comments * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Fix wrong command ID * Provide the weak implementations of default empty stubs * Address review comments * Centralize the TLS Client Management cluster initialization in CodegenIntegration.cpp * Fix namespace mismatch * Update src/app/clusters/tls-client-management-server/CodegenIntegration.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix compile warning * Remove extra check * Adjust the init order * InitializeTlsClientManagement must be called before ChipLinuxAppMainLoop() * Fix incorrect path * Add missing TLS init * Update src/app/clusters/tls-client-management-server/TlsClientManagementCluster.h Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Address review comments * Update src/app/clusters/tls-client-management-server/CodegenIntegration.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address review comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix build errors * Revert TLS certificate changes * Re-run codegen * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Adjust the partition table of esp32 for all-clusters-app --------- Co-authored-by: Pradip De <pradipd@google.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…o code-driven (#42455) (#42740) * Separate PersistenceBuffer out of PersistentStore (#42207) * Separate PersistenceBuffer out of PersistentStore * Refactor CertificateTable to use PersistenceBuffer * Apply suggestion to src/app/storage/FabricTableImpl.ipp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor remaining uses of PersistentStore * Update comments and use an actual deprecation * Replace PersistentData with PersistableData It avoids unnecessary virtual methods and the internal delegate pointer. * Fix comments and go back to comments instead of deprecated attributes The deprecated attributes are causing build failures with -werror=... and working around this with pragmas seems too messy for too little gain. * Make clang-tidy happy Annotate where PersistableData helpers are shadowed with NOLINT. Also tidy up the NOT_FOUND handling in a couple of cases. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * [TLSCERT] Initial PR for conversion to Code Driven - Rename of cluster and associated classes (#42381) * [TLSCERT] Initial PR for conversion to Code Driven - Rename of cluster and associated classes * Update src/app/clusters/tls-certificate-management-server/app_config_dependent_sources.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [TLS-Certificate] Migrate TLS Certificate Management Cluster to code-driven (#42455) * [TLS-Certificate] Migrate TLS Certificate Management Cluster to code-driven * Move CertificateManagementCluster init to CodegenIntegration * Remove extra check in constructor * Address copilot review comments * Fix CI unstable issue * Update src/app/clusters/tls-certificate-management-server/TlsCertificateManagementCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update src/app/clusters/tls-certificate-management-server/TlsCertificateManagementCluster.h Co-authored-by: Andrei Litvin <andy314@gmail.com> * Address review comments * Fix clang-tidy warning * fix unchecked access to optional value --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> --------- Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
…y onto 1.5.1 (#42684) * [TC-ACE-2.4] Add subscription access control test (#41273) * Rebase on origin/master to drop unrelated changes and retain only TC_ACE_2_4 updates in src/python_testing/TC_AccessChecker.py * Refactoring subscription test to match read test pattern more closely * Restyled by autopep8 * Refine INVALID_ACTION error handling in subscription test * Restyled by autopep8 * Update src/python_testing/TC_AccessChecker.py Co-authored-by: C Freeman <cecille@google.com> * removed try/except clause from _run_subscribe_access_test_for_cluster_privilege() for TC_ACE_2_4 * Remove unreachable None check from subscription happy path in TC_ACE_2_4 * Updating runtime default value as TC_ACE_2_4 significantly increases duration * Resolving nodeId issue and adding removing enum.kProxyView as priv level currently disabled in other ACE tests * fixing new linting errors, updating run time of TC_AccessChecker.py * Removing UNSUPPORTED_ACCESS from ACE_2_4 test error path --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: C Freeman <cecille@google.com> * [Framework Update] Adding device reboot functionality to matter_testing module and providing documentation (#42310) * [Framework Update] Adding device reboot functionality to matter_testing module - Created new device_reboot async function in order to perform device reboots and eventually factory resets in CI and local dev environments during testing - Allows this functionality to be easier maintained and reuse as no longer statically set in test modules such as TC_ACL_2_10. * Apply suggestions from code review from Gemini-bot Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Restyled by ruff * Restyled by autopep8 * Adding documentation for the reboot and factory reset functionality to the python.md Support Functionality section. Also adds better doc-str to the device_reboot() in matter_testing * Additional update to the documentation for the reboot and factory reset functionality in the python.md Support Functionality section. * Restylized by autopep8 * Restyled by prettier-markdown * Resolving linting errors * Improve session expiry and simplify documentation: - Add _expire_sessions_on_all_controllers() helper method that uses the fabric admin interface to iterate through all active controllers and expire sessions. - Created request_device_reboot() and request_device_factory_reset() functions in matter_testing module - Updated request_device_reboot() and request_device_factory_reset() functions to use the new private helper method _expire_sessions_on_all_active_controllers() for expiring sessions on all controllers - Simplify documentation in python.md to focus on what test authors need to know (automatic restart in CI vs manual in certification) rather than implementation details This makes the code more robust and works with any controller naming convention. This is an update thanks to the comments and suggestions from Cecille. * Restyled by prettier-markdown * Restyled by ruff * Restyled by autopep8 * Resolving linting errors * Restyled by autopep8 * Changing to ChipStackError instead of plain Exception in _expire_sessions_on_all_controllers() * Restyled by isort * Fixing linting error * Removing unneeded 1 second sleep, changed to using 'APP STATUS: Starting event loop' as the app ready pattern as it is much better * Restyled by autopep8 * Update matter_testing.py Removing 1 second sleep for app-ready-pattern from factory reset function as well, since already reboot from reboot function. * Apply suggestions from code review by Raul Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> * Update matter_testing.py Removing name as per request to keep docstr purely technical * Update python.md Includes changes requested by Raul: - Adds mention that needs to import MatterBaseTest in test module to get this functionality to work. - Adds example command for this functionality when using run_python_test.py test runner * Update python.md * Update python.md * Update python.md Adding space for comment in shell command example syntax * Restyled by prettier-markdown * Update python.md verbiage update for having to import and inherit from the MatterBaseTest class in order to make the request_device_reboot and request_device_factory_reset methods accessible during the test * Restyled by prettier-markdown --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: C Freeman <cecille@google.com> * updated test runtimes comment in TC_AccessChecker.py and test runtime in test_metadata.py * Resolving linting error caused by a log var established in TC_AccessChecker.py from a seperate change PR not yet added to this branch * Restyled by autopep8 * [Quick Fix] Removed enum.kProxyView from privileges tested in TC_AccessChecker.py (#42070) --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com>
…SCertificateManagementCluster (#42731) (#42747) * Rename TlsClientManagementCluster to TLSClientManagementCluster (#42728) * Rename TlsCertificateManagementCluster to TLSCertificateManagementCluster (#42731)
…4) (#42766) * Initial commit to update PanMin/Max and TiltMin/Max to new spec defined ranges * Add use of constants for spec min and max * Restyled by whitespace * Restyled by clang-format * Restyled by autopep8 * Fix bad merge * Correct the range checking for Zoom * Restyled by clang-format * Make zoom min value a known constant --------- Co-authored-by: Restyled.io <commits@restyled.io>
* IDM conformance: use dataclass (#42553) * IDM conformance: use dataclass * undo premature change to generate_spec_xml script * Fix generate script * Add revision to the conformance assessment data * Bad merge * MinimalConformance -> EMPTY_CLUSTER_GLOBAL_ATTRIBUTES * Naming and keywords in initialization * Restyled by isort * Fix one more naming conflict * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io> * Add support for revision conformances in spec (#42661) * Add conformance checks for cluster revision. * Fix lower * check * fix up tests to include revision * Update src/python_testing/matter_testing_infrastructure/matter/testing/conformance.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update src/python_testing/test_testing/TestConformanceSupport.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update src/python_testing/test_testing/TestConformanceSupport.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Use hasattr as a way to appease mypy * Change examples to use rev 2 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * whoops, missed one merge conflict --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…h this time) (#42761) * Python testing framework: Add SDK credentials as data files (#42230) * Python testing: Add PAA/CD files to the package This adds the CD and PAA files from the SDK directly into the python wheel instead of relying on an externally supplied directory. This will allow us to use production CD signing certs to verify the CDs that require CSA signers. * Add production CDs from DCL * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update src/python_testing/matter_testing_infrastructure/matter/testing/credentials.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * bot gettin' spicy with the change demands * fix name on run 2 * Restyled by ruff * Restyled by isort * fix function name in generate_spec_xml * consolidate args per review request --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Device attestation: Reject official CDs signed by test key (#42464) * Add new CDs with different certification types * Update code to make new test cases pass * Add non-test-cd test cases and work around TC-DA-1.2 failure (follow up) * Remove debug prints * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Restyled by clang-format * constexpr * typo in field name for CD * Restyled by clang-format * ok, this is like the third time I've corrected this...what is going on * Update src/credentials/tests/TestCommissionerDUTVectors.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> * TC-DA-1.2: Update for provisional CDs (#42600) * TC-DA-1.2: Update for provisional CDs Previously, testers were expected to have a CD marked as provisional at certification testing. The spec requirements around this were a bit ambiguous, so the test accepted provisional CDs that were signed by any key in the given directory, including a test key. Now we are accepting provisional CDs in production devices, so it would be beneficial to stop asking testers to mint incorrectly signed provisional CDs and warn testers about the difference between a properly signed CD and one of the older "provional" CDs used for testing. A prior PR prevented the default commissioner from permitting official certification type CDs that were signed by the test key, but still permits commissioning with a provisional CD that is signed by the test key (under a flag). A prior PR also added an official zip of the production CSA CD key signers to the test harness. The change in this PR disallows official certification type CDs that are not CSA-signed, and disallows provisional marked CDs that are not CSA-signed, but with an option to bypass with a flag. The bypass was included to allow older test devices to be used with the new tests and will be removed as older spec revisions are sunset. We now also permit test CDs to be used for certification testing. * Restyled by isort * Update src/python_testing/TC_DA_1_2.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update src/python_testing/TC_DA_1_2.py Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Add a manual acknowledgement about provisional CDs with override flag * use an enum for certification type --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Restyled by isort --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
… (#42768) * Fix CMAF interface validation, clip duration calculation, recorded file cleanup and typo Author: Tushant Yadav <t.yadav@samsung.com> * restyle error fix * Address review comments. * Updated directory creation logic and supported interface Author: Tushant Yadav <t.yadav@samsung.com> --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com>
…42769) * Fix Camera app crash on multiple start and stop sessions. Co-Author: Kakadiya Dhruvkumar <kakadiya.b@samsung.com> * Address review comments. * Restyled by whitespace * Update mutex lock name. --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
…r spec. (#42671) (#42773) * [Chime] XML and Zap Regen for Chime Cluster updates per spec. (#42671) * XML and Zap Regen for Chime Cluster updates per spec. * Add missing regen files * Reformat * More reformatting * Address reformat issues * Further format updates * Erroneous spaces * Add missing commas --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> * Zap regen on 1.5 for cherry-picked XML changes --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
…and associated classes (#42279) (#42776) * Rename of cluster * Restyled by whitespace * Restyled by clang-format * Update linter handling --------- Co-authored-by: Restyled.io <commits@restyled.io>
* TC-DD-2.1: Add check for pairing hint (#42674) * TC-SC-4.1 Automation (#41103) * update per latest mdns pr * progress * typo * updates steps * updates test steps * updates steps to query for specific record types * updates steps * adds validations * adds subtype and txt key checks * refactor advertisement checks * restyled/lint checkpoint * restyled * Restyled by autopep8 * Restyled by isort * lint * updates steps * script-testplan match * restyled/lint/steps * Restyled by autopep8 * redact test steps * cleanup * testplan-script match * adds assert_valid_ipv6_addresses * adds command success check * removes obcw command success check * updates * updates logic * checkpoint * checkpoint * restyled * checkpoint * restyled * restyled * checkpoint * restyled * updates get long discriminator logic * temp troubleshoot * temp troubleshoot * restyled tmp * lint * test * get long discriminator implemented * small update * updates test steps * restyled * restyled * skips final steps if extended_discovery_mode is False * refactor getting the long discriminator sybtype, updates steps * restyled * add a second CI run vs lit app * re-enable PI key verifications * remove temp line * typo * Update src/python_testing/TC_SC_4_1.py Co-authored-by: C Freeman <cecille@google.com> * removes unused fn * removes txt record requirement check * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * fixes vp/d key check mismatch * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Update src/python_testing/TC_SC_4_1.py Co-authored-by: Jake Ororke <jororke@csa-iot.org> * lint * removes txt record if returned * checks for the non-presence of the cm subtype when in extended discovery * clarifies ext disc m scenario * grammar * Restyled by autopep8 * updates to verify long or short discriminator * Restyled by autopep8 * lint * updates CI args * updates per latest comments * Restyled by autopep8 * updates param * updates steps * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Jake Ororke <jororke@csa-iot.org> * Fix TC_SC_4_1 in CI (broken sleep usage and conflict with default removal on get_endpoint) (#42142) * Fix CI * Fix CI * TC-SC-4.1: Allow expanded table for pairing hint and add checks for PI (#42675) * TC-SC-4.1: Allow expanded table for pairing hint and add checks for PI * Restyled by autopep8 * Update unit tests * Move to asserts file * Restyled by isort * remove duplicate test --------- Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Jake Ororke <jororke@csa-iot.org> Co-authored-by: Marcos B <15697303+gmarcosb@users.noreply.github.com>
…missioner without ICAC in its chain (#42775) * cherry pick sc_3_5 fix * nit: fixing prompt
* DM XMLs: Remove master directory (#42024) * DM XMLs: Remove master directory The intention was that this directory would be updated regularly and reflect the current master with all includes. That's not been happening and this directory is now deeply out of date. It also doesn't necessarily make sense to have a "master" data model when we have multiple ongoing releases in the spec with different includes. This directory of files is out of date and misleading. Let's remove it for now, and if we decide later that we want to have a dependabot supported pull from master with some set of includes, we can bring it back at that point. But for now, let's get rid of it and avoid confusion. * also remove from CI checks * Data model files for 1.5.1 (#42730) * Add 1.5.1 as a direct copy of 1.5 * Update to alchemy 1.6.8 * Add new files to docs and build * Change current in progress defines to 1.5.1 ballot * Re-scrape at 0.9 ballot tag * Add zip file for 1.5.1 * Add 1.5.1 prebuilt dir and tests * Update the software revision by default * Update expected specification version value in the basic info test * update door lock cluster and device type revisions both new revisios are just related to removing zigbee stuff, which was not present in the first place. * Add the matter file * TC-BINFO-2.1: Fix version check for specification version * zap * Revert zap changes from master zap cersion * Regen zap * add new spec version to test - this was changed on master, so didn't end up in the change set * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
…(#42767) * CameraAVSM code driven file and class name change towards code-driven model (#42311) * File and Class renames for CameraAVSM cluster move to code-driven model. * Rename GetCameraAVStreamMgmtServer() to GetCameraAVStreamManagementCluster(). * Restyle fix. * Relaxing checks for some of the parameters for video and audio stream (#42356) allocation. Remove check against the video stream's keyFrameInterval and relax the equality checks for audio streams' channel count, sample rate and bitdepth. * Migration of CameraAVSM cluster to code driven model (#42224) * Initial changes to moving CameraAVSM to code-driven model. * Modify command processing logic to return Status directly from the command handling methods. * Modify camera-app initialization of CameraAVSM to use code-driven APIs. * Renames and fixes * Add CodegenIntegration.cpp * Fix build errors and issues after rebase. * Restyle fixes * Add unit test for CameraAVSM. * Modify command handlers' arguments to remove unnecessary CommandHandler and CommandPath arguments for some of the commands. * Replace MatterReportingAttributeChangeCallback with NotifyAttributeChanged. * Restyle fixes * Add Register function in camera-app for CameraAVStreamMgmt. * Handle CHIP_ERROR from the setter functions during CameraAVSM init. * Remove CameraAVSM delegate stub from all-clusters-app. The chip-camera-app is the de-facto implementation of the camera application with the CameraAVSM delegate. * Add test functions for commands * Have the CameraAVSM cluster and ClusterTester be a member in the test struct to be usable by each test case. * Add some more attribute units tests. * Merged multiple AppendElements into single call. * Remove feature checks from InvokeCommand since AcceptedCommands already performs those checks. * Incorporate review comments. * Add more attribute read tests to read initialized values. * Remove Camera AVSM cluster from camera-app .zap and .matter files. Also, add the cluster name to the CodeDriven clusters array in config-data.yaml * Address review comments and remove unnecessary stub CodegenIntegration.cpp. * Add camera defaults init function and modify tests for corresponding attributes to validate against those values. * Add the WaterMark feature to the test and add the Video and Snapshot Modify commands. * Add a README file to explain how the application should use this cluster in its code-driven model and not use the ZAP tool for configuration. * Comment out the unit test file for CameraAVSM because of dependency on ClusterTester.h that has associated changes. * Add Camera AVSM cluster into CommandHandlerOnlyInterface list in config-data.yaml
…770) * Fix blindstarttime calculation Co-author: Sambhavi <sambhavi.1@samsung.com> * Fix crash/bug for zone based motion recording on changing transport status Co-author: Sambhavi <sambhavi.1@samsung.com> * update activationTime variable * Ignore blind check in case of Manual trigger Co-author:Sambhavi <sambhavi.1@samsung.com> * Restyled by clang-format * Address Review comments * Address review comments. --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
…de driven( (#42… (#42787) * [AVSUM] Migrate to use of the DefaultServerCluster (code driven( (#42334) * Initial commit to update PanMin/Max and TiltMin/Max to new spec defined ranges * Initial commit for code driven migration * Base working commit * Fix persistence handling * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by prettier-json * Address Gemini comments * Restyled by clang-format * Remove Camera AV from all-clusters (use camera-app for testing) * Fix bad merge * Address further merge issues * Remove unused variables that have migrated to the logic cluster * Compile issue * Add Zap Regen * Handle zap formatting problem * Remove Camera AV Settings from all-clusters * Remove Camera AV * Remove not needed file(s) * Add skeletal unit tests * Fix test build issues * Add unit tests for commands * Fix merge failure * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Fix compile error following merge snafu * restyle * Address clang issues * Restyled by whitespace * Restyled by clang-format * Zap regen * Rework logic so that Clang doesn't complain * Restyled by whitespace * Redo zap changes from scratch * Address code comments. More cleanly handle unit test startup and shutdown. * Rename files as per code comments * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> * Fix bad merge * Fix bad merge * Disable unit test due to missing dependencies * Revert to older Shutdown API * Allow include of string and vector * Regen * Update examples/all-clusters-app/all-clusters-common/all-clusters-app.matter * Remove unused constant * Clean up zap and regen * Fix merge --------- Co-authored-by: Restyled.io <commits@restyled.io>
… (#42681) (#42771) * enhance clip recorder with status enums and error handling * Restyled by clang-format * Apply suggestions from code review Remove redundant `chip::` --------- Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Yufeng Wang <yufengwang@google.com>
…nctionality (#42785) * [Chime] PR#1 - Rename files in preparation for Code-Driven Conversion (#42305) * Rename chime cluster in preparation for codedriven impl * Undo header rename * Restyled by whitespace * Fix typo caught by gemini * Fix typo caught by gemini * Fix typo caught by gemini --------- Co-authored-by: Restyled.io <commits@restyled.io> * Implement Chime cluster as Code driven (#42331) * Rename chime cluster in preparation for codedriven impl * Undo header rename * Restyled by whitespace * Fix typo caught by gemini * Fix typo caught by gemini * Fix typo caught by gemini * chime code-driven * fix conflicts * remove commented out code; add integer bounds * fix commet * Add cluster to codedriven list; zap regen * fix link errors * restyle * fix clang tidy errors * fix member backwards compat member * minimize diffs to make it easier for review * Remove linked list; remove reported chime sounds changed; * fix unit tests; fix default value; reorder more code to minimize diffs * Add Chime Cluster README and PR description * fix init/shutdown; restyle * remove spurious file * Implement Attributed() method * Fix unit test * Fix comments * Fix gemini suggestions * implement AcceptedCommandS() * Address review suggestions * Fix build issue --------- Co-authored-by: Restyled.io <commits@restyled.io> * Fix compile problem * Disable unit tests due to missing dependencies * Remove ToDo * [CHIME] Update chime cluster and test scripts to reflect spec changes (#42745) * Update chime cluster and test scripts to reflect spec changes with new event and command field * Linter errors Update delegate for unit tests * Restyled by whitespace * Restyled by clang-format * Restyled by autopep8 * Restyled by isort * Address review comments * Update all-devices to align with API change --------- Co-authored-by: Restyled.io <commits@restyled.io> * Regen * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * all-devices-app not part of the 1.5 branch. --------- Co-authored-by: Sergio Soares <sergiosoares@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Zaid Omer <zaidomer@google.com>
…pdate and SDK updates (#42772) * Clean up PushAV dummy implementation from all-clusters-app (#42569) * Clean up PushAV dummy implemenation from all-clusters-app * Update examples/all-clusters-app/linux/main-common.cpp Co-authored-by: Sergio Soares <sergiosoares@google.com> * Update examples/all-clusters-app/linux/BUILD.gn Co-authored-by: Sergio Soares <sergiosoares@google.com> --------- Co-authored-by: Sergio Soares <sergiosoares@google.com> * [Camera] Update camera xml definitions to align with the latest spec (#42599) * Update camera xml defination to align with spec update * Re-run codegen * [Camera SDK 1.5.1] Push AV Max Pre Roll Length Validation (#42713) * 1.5.1 Push AV - Add MaxPreRollLen validation. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by whitespace * Restyled by clang-format * Update API description and validation check Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by clang-format * Address review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Correct MaxPreRollLengh value to fix TC failure. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Address review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Address review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> * [Camera SDK 1.5.1] Implement Push AV multi stream support (#42741) * 1.5.1 Push AV Multistream support. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Implement the constraint to add streamIDs to streams list. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Return INVALID_IN_STATE on select stream failure. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Add Constraint checks for audio and video streams. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by whitespace * Restyled by clang-format * Address geminibot review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Use audio video streams for bandwidth calculation and for media Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Implement PAVST_2_11. Co-Author: Dhruvkumar <kakadiya.d@samsung.com> Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Update validation check for bandwidth limit Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Handle PushTransportBegin event as per new spec 1.5.1 Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Fix CI failures. Co-Author: Dhruvkumar <kakadiya.b@samsung.com> Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by ruff * Restyled by autopep8 * Restyled by isort * Fix LINT errors. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Remove CMAF track name validation as it is deprecated in 1.5.1 Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Fix CI failures. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by clang-format * Update Mock Tests. Signed-off-by: Raveendra Karu <r.karu@samsung.com> --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> * Fix zap generation issue --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: Sergio Soares <sergiosoares@google.com> Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
…quence of the record clip files (#42860) * Move SFrame encryption into each transport's RTP packetization logic (#42367) * Zone Management and Push AV Stream Transport clusters handle zone events independently (#42368) * Zone Management and Push AV Stream Transport clusters handle zone events independently * Remove dead code * Update examples/camera-app/linux/src/camera-device.cpp Co-authored-by: [Samsung] Vishnu Kavali <58797059+vnkavali@users.noreply.github.com> --------- Co-authored-by: [Samsung] Vishnu Kavali <58797059+vnkavali@users.noreply.github.com> * [Push AV 1.5.1] Update upload sequence of the record clip files (#42370) * initial changes for PushAV for 1.5.1 release Co-author: Tushant Yadav <t.yadav@samsung.com> Co-author: Sambhavi <sambhavi.1@samsung.com> * restyle fix Author: Tushant Yadav <t.yadav@samsung.com> * bug fixes Author: Tushant Yadav <t.yadav@samsung.com> * Integrate the CMAFSessionNumber API and rebase changes. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by whitespace * Restyled by clang-format * Implement Motion zone trigger Test Cases. Co-Author: Sambhavi <sambhavi.1@samsung.com> Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Reset clip elapsed time correctly. Co-Author: Tushant Yadav <t.yadav@samsung.com> Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by clang-format * Restyled by ruff * Restyled by autopep8 * Restyled by isort * Resolve LINT errors. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Update TC_PAVST_2_12 and address review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by autopep8 * Update TC_PAVST_2_13 as per new test plan. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Update unique --app-pipe for PAVST_2_11 to PAVST_2_13 TCs. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Address Review comments. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Use gstreamer Audio Video test sources for PAVST_2_13 and PAVST_2_12 TCs. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Validate Stream params on ModifyPushTransport. Co-Author: Tushant Yadav <t.yadav@samsung.com> Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by clang-format * Updated stream validation and TC failure Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by ruff * Restyled by autopep8 --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> * Fix Lint error: Revert PRId64 usage in 1.5-branch --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Yufeng Wang <yufengwang@google.com> Co-authored-by: [Samsung] Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
…RTC session establishment (#42827) (#42859) * [Camera] Remove non-delegate APIs from CameraAVStreamManagementDelegate (#42812) * Remove non-delegate APIs from CameraAVStreamManagementDelegate * Address copilot review comments * Remove unused params from EndSession (#42814) * CodegenIntegration.h needs to be in app_config_dependent_sources.gni (#42829) * CodegenIntegration.h needs to be in app_config_dependent_sources.gni * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [WebRTC] Support multiple streams during WebRTC session establishment (#42827) * Add multi stream support in WebRTC * Support multiple streams in Connection * Update usage parameters * Fix CI failures * Revert test plan changes * Use a templated helper approach that reduces the boilerplate (#42394) * Fix include check error --------- Co-authored-by: Restyled.io <commits@restyled.io>
… Testplan PR 5640 (#42832) (#42857) * Add CameraAVSM test scripts for test cases in CameraAVSM Testplan PR 5640 (#42832) * Add CameraAVSM test scripts for test cases in testplan PR CHIP-Specifications/chip-test-plans#5640 * Fixes for copilot review comments * Add the app-ready-pattern for the app to signal when it is back after (#42883) restarting so that the test script can connect back.
silabs-matter-ci-bot
bot
force-pushed
the
automation/update_release_2.8-1.5
branch
from
db91726 to
619988e
Compare
…42923) * [WebRTCP] Identify duplicated logic around stream handling and consolidate it. (#42864) * Identify duplicated logic around stream handling and consolidate it. * Addres copilot comments * Fix build error * [Camera] Fix camera app crashes on unexpected SDPs (#42875) * Fix camera app crashes on unexpected SDPs * Address review comments * Add extra mandatory fields check * AVSUM: Use NotifyAttributeChanged instead of MatterReportingAttributeChangeCallback (#42909) * AVSUM: Use NotifyAttributeChanged instead of MatterReportingAttributeChangeCallback Replace legacy MatterReportingAttributeChangeCallback with NotifyAttributeChanged for CameraAvSettingsUserLevelMgmtServerLogic. This aligns with the code-driven cluster pattern where NotifyAttributeChanged properly increments the cluster data version and notifies through the ServerClusterContext. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Breaks the circular dependency --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…dex lookup failure (#42951) * [TLSCERT] Split the TC_TLSCERT.py file into separate test files (#42903) * Split the TC_TLSCERT.py file into separate test files * Address copilot comments * Do not automate TC_TLSCERT_Base.py * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io> * [TLSCLIENT] Split the TC_TLSCLIENT.py file into separate test files (#42904) * [TLSCLIENT] Split the TC_TLSCLIENT.py file into separate test files * Address copilot comments * Do not automate TC_TLSCLIENT_Base.py * Restyled by whitespace * Delete extra file --------- Co-authored-by: Restyled.io <commits@restyled.io> * Fix failed fabric removal due to TLS enpoint's fabric index lookup failure (#42937) * Fix unit test errors --------- Co-authored-by: Restyled.io <commits@restyled.io>
…(#42955) (#42999) * Consolidate cleanup sites to use the shared CleanupSession (#42954) * consolidate cleanup sites to use the shared CleanupSession(sessionId) * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add missing logic --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add a connection timeout timer to clean up the stale session. (#42952) * Add a connection timeout timer to clean up the stale session. * Use CancelConnectionTimer instead of checking state * Address review comment * Schedule pending timer cleanup * [WebRTC] Parse and set ICE servers to PeerConnection (#42955) * [WebRTC] Parse and set ICE servers to PeerConnection * Address review comments * Fixes WEBRTCP and AVSM for TC-IDM tests (#42971) * Fixes camera clusters for tc-idm tests * Restyled by clang-format * Address comments --------- Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: SAYON DEEP <sayondeep0710@rediffmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
… (#43019) * [Ameba] Fix Wi-Fi connection handling and server initialization order (#42912) * Prevent commissioning failure when the first Wi-Fi connection attempt is temporarily rejected. Start a connection timeout timer and report ConnectWiFiNetworkFailed to the controller only if the timeout expires. * Ensure SetDeviceInfoProvider completes before server initialization when supporting FixedLabel, UserLabel, Localization, or TimeFormatLocalization. Reorder initialization sequence accordingly.
…42672) (#42805) * Shot in the dark at fixing TCP memory leak in #42006 (#42672) * Shot in the dark at fixing memory leak in #42006 Test unfortunately does not repro the leak, but seems like a good test to have regardless Test doesn't repro because it seems unauthenticated session is immediately discarded * Apply review suggestions * Apply review suggestions * Fix fake tests & add additional attempt to cleanup the leak by trying to notify references of closed connection * Disable TestTCPConnection.cpp in v1.5 because of Testing namespace changes. --------- Co-authored-by: Marcos B <15697303+gmarcosb@users.noreply.github.com>
…ed TXT record T key verification; fix discriminator subtype lookup (#43390) * Align TC-SC-4.1 and TC-SC-4.3 with updated TXT record T key verification; fix discriminator subtype lookup (#42933) * Adds a TCP enabled version of the ci-pics-values file, added file: `ci-pics-values-tcp` * Fixes missing TXT record T key advertising for commissionable nodes when TCP is enabled * * Updates discriminator subtype presence verification to require an exact match, avoiding false positives when multiple discriminators or DUTs are present on the network * Updates TCP bit (0x04) verification to only assert when TCP is enabled * Updates CI test scenarios to enable TCP in the PICS (TCP is enabled in the app by default) * adds clarifying comment * removes dedundant T key verification * removes ci-pics-values-tcp, adds MCORE.SC.TCP=1 to ci-pics-values * removes ci-pics-values-tcp reference * adds MCORE.SC.TCP to PICS.yaml * removes unnecessary variable * updates T key verification logic * removes redundant T key bit 0 check * * absorb extra t key verifications into assert_valid_t_key * adds is_dut_tcp_supported to mdns network utils * updates assert_valid_t_key unit tests * log=false on txt record fetch * re-number steps * Restyled by ruff * updates TC-SC-4.3 as per T key verification fix * restores Dnssd. cpp/h * updates mdns class readme * Restyled by prettier-markdown * adds/refactors tcp support checks * re-order steps * adds dut tcp check for t key verifications * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 2bb1baf) * Restyled by autopep8 * Apply restyled fixes * Revert unintentional submodule changes --------- Co-authored-by: Restyled.io <commits@restyled.io>
…ster's EFS value (#43368)
…to close (#43565) (#43578) * Fix TC_WEBRTC_1_6.py failure by ignoring NOT_FOUND status response on invoking EndSession The test case was failing as EndSession is called at step 9. Since on closing the browser popup, the peer connection gets closed. Some implementations can remove the session in CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence it update TC_WEBRTC_1_6.py to ignore any NOT_FOUND status response for EndSession command. * Address review comment: Silence only NotFound interaction response --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: chulspro <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com>
…me (#43136) (#43564) * Increase blind duration and transport expiry time Co-Author: Dhruvkumar <kakadiya.b@samsung.com> * Update asyncio timeout and address review comments. * Add comments to explain the reason for choosing time control fields values. --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com>
…43575) (#43595) * setup: add pydantic-core constraint for Python 3.13+ compatibility pydantic-core < 2.20 ships no pre-built wheels for cp313 and attempts to build from source using PyO3 0.21.x which does not support Python 3.13+, causing bootstrap to fail. Add a version-gated constraint so pip resolves a compatible pydantic-core when running on Python >= 3.13. * suggestion from gemini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa-v1.5-branch branch with the release_2.8-1.5 branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION