[DRAFT] Matter BLE Side Channel Enhancements (#760)#788
Draft
Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.6-1.4from
Draft
[DRAFT] Matter BLE Side Channel Enhancements (#760)#788Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.6-1.4from
Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.6-1.4from
Conversation
* Update BLE Side channel code to allow user SideChannel implementation. Allow Side channel to select ble Events it wants to parse. Add option to use our test side channel * Apply suggestions from code review Co-authored-by: sarthak shaha <sarthak.shaha@silabs.com> * fix restyle * Add logic to prevent Matter BLE event to be passed to the side channel. Move all Side channel event parsing to the bleSideChannel implementation. --------- Co-authored-by: sarthak shaha <sarthak.shaha@silabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update BLE Side channel code to allow user SideChannel implementation. Allow Side channel to select ble Events it wants to parse. Add option to use our test side channel
Apply suggestions from code review
fix restyle
Add logic to prevent Matter BLE event to be passed to the side channel. Move all Side channel event parsing to the bleSideChannel implementation.
Summary
Related issues
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines