feat(test): Add soc_multilevel_sensor app #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Jul 21, 2025
Only one app per type is supported, it may be improved later if needed Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Jul 21, 2025
Ror the record, I have been running this test during 24+ hours, no issue observed, except a wrong homeid after inclusion (see TODO), This will need to be investigated. Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
phcoval/test/review/main
branch
from
84ecdad to
f12df7d
Compare
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Jul 21, 2025
A loop feature was added to run endurance tests, It was tested for 24+h along the next commit for sensor and an issue has been observed, it will need deeper investigation, check related tickets. Only one app per type is supported, it may be improved later if needed Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Jul 21, 2025
Ror the record, I have been running this test during 24+ hours, no issue observed, except a wrong homeid after inclusion (see TODO), This will need to be investigated. Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
phcoval/test/review/main
branch
from
f12df7d to
ac2ea53
Compare
A loop feature was added to run endurance tests, It was tested for 24+h along the next commit for sensor and an issue has been observed, it will need deeper investigation, check related tickets. Only one app per type is supported, it may be improved later if needed Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
Ror the record, I have been running this test during 24+ hours, no issue observed, except a wrong homeid after inclusion (see TODO), This will need to be investigated. Origin: SiliconLabsSoftware#135 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#76 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
phcoval/test/review/main
branch
from
ac2ea53 to
def310f
Compare
lmolina
reviewed
Jul 29, 2025
| controller_cli_ H | ||
| controller_cli_ n | ||
|
|
||
| log_ "net: $command: Use controller: $contid" |
There was a problem hiding this comment.
polish: ensure that $contid is set?
There was a problem hiding this comment.
good idea, can do same with homeid
testing could be improved on each steps
I will think about it in later change (i dont want to divert too much to the origin)
|
|
||
| local command="add_node" | ||
| log_ "net: $command: Node should not be included: $nodeid ($node)" | ||
| node_cli_ "$node" H |
There was a problem hiding this comment.
issue: shouldn't be n? H will not set nodeid and the following validation will never fail?
There was a problem hiding this comment.
i think i am updating homeid because it is used later in unid (along nodeid)
| sleep 1 | ||
| case $1 in | ||
| h) | ||
| echo "node: Should display help" | ||
| echo "node: ${node}: Should display help" | ||
| ;; | ||
| d) | ||
| DSK=$(grep 'DSK: ' "${node_log}" \ |
There was a problem hiding this comment.
piggyback on this PR?
Suggested change
| DSK=$(grep 'DSK: ' "${node_log}" \ | |
| local DSK=$(grep 'DSK: ' "${node_log}" \ |
| local app="$1" | ||
| [ "" != "$app" ] || app="soc_switch_on_off" | ||
| local app_file=$(realpath \ | ||
| "${z_wave_stack_binaries_bin_dir}/ZW_zwave_${app}_"*"_REALTIME"*".elf" \ |
There was a problem hiding this comment.
question(non-blocking): is it possible to mix applications in debug and release? Not a big issue if we assume that there's only one binary per application. If the assumption is true, then head -n1 may not be needed?
There was a problem hiding this comment.
you can add an envvar to select the build mode
| log_ "$task: broker is ready, operating for ${duration} mins" | ||
| local args="" | ||
| [ $CONFIG_PLAY_LOOP ] || args="$args -W $((60 * ${duration}))" | ||
| mosquitto_sub -v -t '#' $args |
There was a problem hiding this comment.
unsure on it did you try ? it is not a single option
Co-authored-by: Laudin Alessandro Molina Troconis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Checklist