feat(nbt): add serializers for tags and item stack#40
Open
SettingDust wants to merge 6 commits intoSilkMC:mainfrom
Open
feat(nbt): add serializers for tags and item stack#40SettingDust wants to merge 6 commits intoSilkMC:mainfrom
SettingDust wants to merge 6 commits intoSilkMC:mainfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
TODO: add unit tests for serializers
SettingDust
force-pushed
the
feature/nbt_serializers
branch
from
d45de04 to
26f2f3a
Compare
1 task
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Thanks, will check it out in a few days, ping me if I forget it. |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Looking good so far - cloned it locally, I'll add a few commits to this PR and then request a review from f0x. |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: SettingDust <settingdust@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.