Boundary integral file time step 309 #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The errors are caused by exceptions thrown by the integration functions (e.g. |
dcodoni
reviewed
Dec 18, 2024
Contributor
dcodoni
left a comment
dcodoni
left a comment
There was a problem hiding this comment.
Very good! I only have one comment/question.
dcodoni
approved these changes
Dec 18, 2024
divyaadil23
pushed a commit
to divyaadil23/svFSIplus
that referenced
this pull request
Jan 29, 2025
* Change file name. * Add functionality to write integral quantities and replace using wtn Boolean vector. * Remove initialization of output type options to true. * Fix test for integrals. * Remove redundant loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed writing integral quantities (see #309).
I've also updated
svMultiPhysics/tests/cases/fluid/pipe_RCR_3dto write integral quantities since this is not tested anywhere.