Skip to content

Conversation

@msbazzi
Copy link
Contributor

@msbazzi msbazzi commented Dec 13, 2024

Fixing bugs associated to prismatic/wedge mesh #312

Current situation

We have the capabilities to solve equations on prismatic/wedge grids, but there are some bugs to be fixed.

Release Notes

The bugs relative to the prismatic grids usage in the solver are fixed.

Documentation

NA

Testing

The tests are not ready yet. They will be provided in the next PR.

Code of Conduct & Contributing Guidelines

@msbazzi msbazzi requested review from dcodoni and ktbolt December 13, 2024 02:46
@ktbolt ktbolt self-requested a review December 13, 2024 23:39
Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ktbolt
Copy link
Collaborator

ktbolt commented Dec 13, 2024

@msbazzi Be sure to add your wedge test to tests/cases.

@ktbolt ktbolt merged commit ad7913c into SimVascular:main Dec 16, 2024
5 checks passed
@msbazzi msbazzi deleted the prismatic_mesh branch January 7, 2025 00:10
divyaadil23 pushed a commit to divyaadil23/svFSIplus that referenced this pull request Jan 29, 2025
* Fixing bugs associated to wedge element type

* Restoring some files

* Fixing indentation and removing unnecessary warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants