-
Notifications
You must be signed in to change notification settings - Fork 46
Check constitutive model ustruct 320 #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ktbolt
merged 18 commits into
SimVascular:main
from
ktbolt:check-constitutive-model-ustruct_320
Jan 8, 2025
Merged
Check constitutive model ustruct 320 #321
ktbolt
merged 18 commits into
SimVascular:main
from
ktbolt:check-constitutive-model-ustruct_320
Jan 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabrown100-git
approved these changes
Jan 7, 2025
Collaborator
aabrown100-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one comment typo, it all looks good to me!
divyaadil23
pushed a commit
to divyaadil23/svFSIplus
that referenced
this pull request
Jan 29, 2025
* Change file name. * Add functions to check for a valid constitutive model for ustruct equations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for a valid material model for ustruct equations from
mat_models::get_pk2cc()toConstitutiveModelParameters::check_constitutive_model().See #320.