Skip to content

Conversation

@msbazzi
Copy link
Contributor

@msbazzi msbazzi commented Jan 7, 2025

Fixing face match bug #323

Current situation

The code generated a segmentation fault type error when setting a traction boundary condition type.

Release Notes

Changed line 126 in face_match function to loop over lFa.nNo instead gFA.nNo

Testing

No test required

Code of Conduct & Contributing Guidelines

@msbazzi msbazzi requested review from dcodoni and ktbolt January 7, 2025 00:29
Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ktbolt ktbolt merged commit 1ee791c into SimVascular:main Jan 7, 2025
5 checks passed
@msbazzi msbazzi deleted the Face_match_bug branch January 7, 2025 18:41
divyaadil23 pushed a commit to divyaadil23/svFSIplus that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants