Skip to content

Conversation

@menon-karthik
Copy link
Member

Current situation

Closes #415

Release Notes

Updated the README

Documentation

This is the documentation.

Testing

N/A

Code of Conduct & Contributing Guidelines

@menon-karthik menon-karthik changed the title Update REAME with correct command for using local VTK install Update README with correct command for using local VTK install Jul 20, 2025
@menon-karthik menon-karthik requested a review from ktbolt July 20, 2025 20:22
Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@menon-karthik Thanks for fixing this !

@aabrown100-git
Copy link
Collaborator

Something's wrong with the checks on this PR. It's waiting for the test check to complete, but it never does. That is because in this commit, we changed the code so that tests are run only when files in the Code/ and test/ folder are changed.

@aabrown100-git
Copy link
Collaborator

aabrown100-git commented Aug 1, 2025

One solution suggested by chatGPT is to create a dummy job within test_macos.yaml and test_ubuntu.yaml that always runs. The actual testing would run only if files in the Code/ and test/ folders are changed.

@aabrown100-git
Copy link
Collaborator

aabrown100-git commented Sep 2, 2025

I've considered a few options to resolve this, but none are great options

  1. Undo the changes that made tests run only when code is changed (this PR). We made this PR because we didn't want all our tests to run when only a README or something is changed. But these types of PRs are relatively rare, and it might be more straightforward (albeit slightly more inefficient) to just have tests run for these types of PRs.
  2. Add a dummy test job that always runs and returns a success status. The downside is that solution is kind of clunky and very specific to this one case that isn't actually that common.
  3. Reorganize the tests and branch protection rules. Requires a bit more investigation and work, but could lead to the cleanest solution.

@ktbolt
Copy link
Collaborator

ktbolt commented Sep 3, 2025

@aabrown100-git The cleanest solution is always the best solution so let's figure out the correct yaml rules.

It might be easier to create dummy repository for testing.

@aabrown100-git
Copy link
Collaborator

aabrown100-git commented Sep 23, 2025

Because #430 was just merged, the macOS and Ubuntu integration tests are skipped, but the required All Tests still passes, so we are able to merge.

@aabrown100-git aabrown100-git merged commit 2efe9a4 into SimVascular:main Sep 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README has wrong commands for using local VTK build

3 participants