Fix boundary writing issue #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For simulation with multiple meshes, the output txt file should be closed after it loops over all meshes.
dseyler
added a commit
to dseyler/svMultiPhysics
that referenced
this pull request
Aug 25, 2025
Fix boundary writing issue (SimVascular#420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simulation with multiple meshes, the output txt file should be closed after it loops over all meshes.
Current situation
The boundary‐integral output file was being closed inside the per‑mesh loop, triggering a “double free or corruption” error and crashing the solver on the first iteration.
Release Notes
The file is now closed only after iterating over all meshes.
Code of Conduct & Contributing Guidelines