Updating CMake file #425
Merged
Updating CMake file #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version if it is not defined or empty string
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 65.65% 65.88% +0.23%
==========================================
Files 114 163 +49
Lines 29416 31822 +2406
Branches 0 5202 +5202
==========================================
+ Hits 19312 20967 +1655
- Misses 10104 10717 +613
- Partials 0 138 +138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating CMake file to fetch the correct version of MacOS (address #426 )
Current situation
The new macOS runner image on GitHub Actions no longer provides the current macOS version in a way that current CMake file expect. As a result, builds on macos-latest fail at the configuration stage due to the simvascular_get_major_minor_version macro receiving an empty value.
Release Notes
SimVascularSystemSetup.cmake file has been updated to explicitly query the current macOS version using the system command sw_vers -productVersion. This ensures that the major and minor macOS version numbers are correctly detected during configuration, allowing builds on GitHub Actions macOS runners to succeed.
Documentation
No documentation needed.
Testing
No need for test.
Code of Conduct & Contributing Guidelines