-
Notifications
You must be signed in to change notification settings - Fork 47
Adding test cases for reading of fourier coefficient file #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 66.90% 67.07% +0.17%
==========================================
Files 165 166 +1
Lines 33711 33746 +35
Branches 5672 5673 +1
==========================================
+ Hits 22553 22636 +83
+ Misses 11020 10972 -48
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aabrown100-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with this! Just added a few suggestions and questions for clarification.
|
@aabrown100-git Having a script in a test directory means that it does something else than just testing the solver. The Python script is indeed useful so let's put it someplace users can find it ! I can add documentation for a |
aabrown100-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, love the extensive documentation!
|
@ktbolt, can we merge or did you want to review it one last time? |
|
Very nice documentation I agree ! |
Adds a test case that reads in Fourier coefficients for boundary condition and fixes the read io bug.
Current situation
Resolves #418 (indexing issue when reading in Fourier coefficient files)
Release Notes
Documentation
Code is documented with comments. Test case includes an updated README.
Testing
Test case is included as pipe_RCR_3d_fourier_coeff. Unit test has also been included.
Code of Conduct & Contributing Guidelines