Skip to content

Conversation

@aabrown100-git
Copy link
Collaborator

Removed redundant installation of cmake from MacOS dependencies.

Current situation

MacOS tests were failing because of

Error: cmake was installed from the local/pinned tap
but you are trying to install it from the homebrew/core tap.
Formulae with the same name from different taps cannot be installed at the same time.

To install this version, you must first uninstall the existing formula:
  brew uninstall cmake
Then you can install the desired version:
  brew install cmake

Release Notes

  • Remove cmake from list of packages installed by brew

Testing

  • No testing, will see if macos tests pass with this change.

Code of Conduct & Contributing Guidelines

Removed redundant installation of gcc from MacOS dependencies.
Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.90%. Comparing base (acc51f2) to head (d68edc1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         165      165           
  Lines       33711    33711           
  Branches     5672     5672           
=======================================
  Hits        22553    22553           
  Misses      11020    11020           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktbolt ktbolt merged commit 045220a into SimVascular:main Sep 9, 2025
6 checks passed
@aabrown100-git aabrown100-git deleted the aabrown100-git-patch-1 branch September 11, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants