Fiber direction spatial output seg fault 432 #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 67.15% 67.42% +0.26%
==========================================
Files 169 169
Lines 34152 34142 -10
Branches 5727 5727
==========================================
+ Hits 22936 23021 +85
+ Misses 11077 10983 -94
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aabrown100-git
requested changes
Sep 23, 2025
Collaborator
aabrown100-git
left a comment
aabrown100-git
left a comment
There was a problem hiding this comment.
Looks good, but could you modify a test case to test that it works? I think you could just add 'Fiber_stretch' as a spatial output in the LV_HolzapfelOgden_active case, for example, and just verify that it doesn't seg fault
…tial-output-seg-fault_432
…pdate the result_001.vtu testing file.
Collaborator
|
Looks good! |
kko27
pushed a commit
to kko27/svMultiPhysics
that referenced
this pull request
Dec 17, 2025
* Change file name. * Fix some indexing and scope bugs. * Add the 'Fiber_direction' Output command to the solver.xml file and update the result_001.vtu testing file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was never tested. I have found and fixed several bugs (see #432).