Fixed bug for using uris mesh max eNoN and scale factor. #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabrown100-git
approved these changes
Sep 23, 2025
Collaborator
aabrown100-git
left a comment
aabrown100-git
left a comment
There was a problem hiding this comment.
Looks good to me!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 166 166
Lines 33746 33748 +2
Branches 5673 5674 +1
=======================================
+ Hits 22636 22638 +2
Misses 10972 10972
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kko27
pushed a commit
to kko27/svMultiPhysics
that referenced
this pull request
Dec 17, 2025
…#436) Co-authored-by: Aaron Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs in the current URIS code for using the maximum eNoN when resizing an array, and added missing mesh scale factors for valve position.
Testing
The code is tested using URIS test cases.
Code of Conduct & Contributing Guidelines