Skip to content

RIS valve mesh scale factor bug fix #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aabrown100-git merged 10 commits into from
Oct 27, 2025
Merged

RIS valve mesh scale factor bug fix #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee253de
Fixed bug for using uris mesh max eNoN and scale factor.
hanzhao2020 Sep 23, 2025
a5c145e
Merge branch 'main' into ris_bug_fix
aabrown100-git Sep 23, 2025
c0df9ff
Merge branch 'SimVascular:main' into ris_bug_fix
hanzhao2020 Sep 25, 2025
2f9b664
Fixed bugs for RIS valve with mesh scale factor other than 1
hanzhao2020 Sep 25, 2025
6bcc4a5
Merge branch 'main' into ris_bug_fix
aabrown100-git Sep 26, 2025
99c81a3
Merge branch 'main' into ris_bug_fix
aabrown100-git Sep 26, 2025
eacafa8
Merge branch 'main' into ris_bug_fix
aabrown100-git Oct 4, 2025
03c576c
Merge branch 'SimVascular:main' into ris_bug_fix
hanzhao2020 Oct 18, 2025
be02269
Changed default RIS valve signed distance function to a large value
hanzhao2020 Oct 18, 2025
0192914
Merge branch 'main' into ris_bug_fix
aabrown100-git Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Code/Source/solver/ComMod.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,10 +1456,10 @@ class urisType
Array<double> Yd;

// Default signed distance value away from the valve.
double sdf_default = 10.0;
double sdf_default = 1000.0;

// Default distance value of the valve boundary (valve thickness).
double sdf_deps = 0.04;
double sdf_deps = 0.25;

// Default distance value of the valve boundary when the valve is closed.
double sdf_deps_close = 0.25;
Expand Down
10 changes: 6 additions & 4 deletions Code/Source/solver/uris.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,9 @@ void uris_read_msh(Simulation* simulation) {
}
file_stream.close();

uris_obj.sdf_deps = param->thickness();
uris_obj.sdf_deps_close = param->close_thickness();
uris_obj.sdf_default = uris_obj.sdf_default * uris_obj.scF;
uris_obj.sdf_deps = param->thickness() * uris_obj.scF;
uris_obj.sdf_deps_close = param->close_thickness() * uris_obj.scF;
uris_obj.clsFlg = param->valve_starts_as_closed();

// uris_obj.tnNo = 0;
Expand Down Expand Up @@ -779,7 +780,8 @@ void uris_write_vtus(ComMod& com_mod) {
for (int a = 0; a < mesh.nNo; a++) {
int Ac = mesh.gN(a);
for (int i = 0; i < nsd; i++) {
d[iM].x(i,a) = uris_obj.x(i,Ac);
// Scale the valve displacement to the unit of the mesh
d[iM].x(i,a) = uris_obj.x(i,Ac) / uris_obj.scF;
}
}
for (int e = 0; e < mesh.nEl; e++) {
Expand All @@ -802,7 +804,7 @@ void uris_write_vtus(ComMod& com_mod) {
for (int a = 0; a < mesh.nNo; a++) {
int Ac = mesh.gN(a);
for (int i = 0; i < nsd; i++) {
d[iM].x(is+i,a) = uris_obj.Yd(s+i,Ac); // [HZ] Need to check this
d[iM].x(is+i,a) = uris_obj.Yd(s+i,Ac) / uris_obj.scF; // [HZ] Need to check this
}
}

Expand Down
Loading