Add BSD-3-Clause license and standardize headers with SPDX format #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LICENSE.txt with BSD-3-Clause license to repository root - Replace lengthy 29-line license headers with clean 2-line SPDX format - Update 196 source files (.cpp, .h, .c) with SPDX headers - Update .github/workflows/copyright.yml to check for SPDX headers - Update Copyright-SimVascular.txt to reference SPDX format - Add update_license_headers.py script for future maintenance All source files now use standardized SPDX identifiers: // SPDX-FileCopyrightText: Copyright (c) Stanford University, The Regents of the University of California, and others. // SPDX-License-Identifier: BSD-3-Clause Fixes SimVascular#451 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…tandardize-license
- Update update_license_headers.py to handle /** Javadoc-style comments - Merge latest changes from upstream main - Add SPDX headers to newly added BoundaryCondition files - Fix SPDX header in Tensor4.cpp (was using /** style) Files updated: - Code/Source/solver/BoundaryCondition.cpp - Code/Source/solver/BoundaryCondition.h - Code/Source/solver/RobinBoundaryCondition.cpp - Code/Source/solver/RobinBoundaryCondition.h - Code/Source/solver/Tensor4.cpp All 205 source files now pass SPDX license header check. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
mrp089
requested changes
Oct 13, 2025
Member
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Thanks @Eleven7825! See comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 67.45% 67.45%
=======================================
Files 170 170
Lines 34173 34173
Branches 5736 5736
=======================================
Hits 23050 23050
Misses 10985 10985
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Per reviewer feedback on PR SimVascular#452: 1. Update .licenserc.json to check for SPDX headers instead of old format 2. Update copyright.yml to use [email protected] (from v1.0.6) 3. Remove update_license_headers.py from commit (kept locally for reference) 4. Update LICENSE.txt to match svZeroDSolver exactly (Copyright 2016-2025) 5. Remove Copyright-SimVascular.txt (replaced by LICENSE.txt) The .licenserc.json now checks for: - C/C++ files: SPDX-FileCopyrightText and SPDX-License-Identifier - Python files: Same SPDX format with # comments - Maintains same ignore patterns for third-party code
The kt3k/license_checker action is archived (max v1.0.6). Use the deno_license_checker v3.3.1 with Deno runtime instead. This runs: deno run --allow-read jsr:@kt3k/[email protected] which uses the .licenserc.json configuration.
mrp089
requested changes
Oct 14, 2025
- Remove .c from copyright.yml comment (no .c files in Code/) - Remove *.py section from .licenserc.json (no .py files in Code/) - Remove update_license_headers.py from .gitignore per reviewer request
Collaborator
Author
mrp089
approved these changes
Oct 15, 2025
kko27
pushed a commit
to kko27/svMultiPhysics
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All source files now use standardized SPDX identifiers:
// SPDX-FileCopyrightText: Copyright (c) Stanford University, The Regents of the University of California, and others.
// SPDX-License-Identifier: BSD-3-Clause
Fixes #451
🤖 Generated with Claude Code