Fixed unknown coupled BC type when using genBC or svZeroD solver in FSI #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 169 169
Lines 32620 32620
Branches 5718 5718
=======================================
Hits 21970 21970
Misses 10513 10513
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktbolt
reviewed
Oct 29, 2025
…id unknown BC type error in FSI
kko27
pushed a commit
to kko27/svMultiPhysics
that referenced
this pull request
Dec 17, 2025
…SI (SimVascular#463) * Fixed unknown coupled BC type when using genBC or svZeroD solver in FSI * Change coupled BC if statement back to previous implementation to avoid unknown BC type error in FSI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Solves #462
Release Notes
FSI simulation with genBC or svZeroDSolver coupled boundary conditions produces
Unknown coupled BC typeerror becausecplBC.useGenBCorcplBC.useSvZeroDare already true when reading the mesh motion equation, even though they are not defined for the mesh motion equation. An additional check forcplbc_type_stris added to avoid checking the coupled BC type for the mesh motion equation.Testing
Tested using the 3D pipe case in FSI with both svZeroD solver and genBC.
Code of Conduct & Contributing Guidelines