Skip to content

Conversation

@aabrown100-git
Copy link
Collaborator

@aabrown100-git aabrown100-git commented Oct 31, 2025

Current situation

#466

Release Notes

  • Deletes lpn_interface.cpp

Documentation

No documentation necessary.

Testing

Existing sv0D tests still pass.

Code of Conduct & Contributing Guidelines

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the entire lpn_interface.cpp file, which provided the C interface layer between Fortran code and the C++ LPNSolverInterface for 0D lumped parameter network (LPN) simulations. The file contained approximately 218 lines implementing various interface functions for model initialization, state management, parameter updates, and simulation execution.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.35%. Comparing base (4db1403) to head (5e28d3c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   67.35%   67.35%           
=======================================
  Files         169      169           
  Lines       32620    32620           
  Branches     5718     5718           
=======================================
  Hits        21970    21970           
  Misses      10513    10513           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabrown100-git aabrown100-git mentioned this pull request Nov 3, 2025
1 task
@menon-karthik menon-karthik merged commit 0ae6a5c into SimVascular:main Nov 3, 2025
14 checks passed
@aabrown100-git aabrown100-git deleted the remove_lpn_interface branch November 4, 2025 05:15
kko27 pushed a commit to kko27/svMultiPhysics that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants