Add simple blocks #155
Closed
Add simple blocks #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/model/Block.h: Language not supported
- src/model/BlockType.h: Language not supported
- src/model/BloodVessel.h: Language not supported
- src/model/CMakeLists.txt: Language not supported
- src/model/Capacitance.cpp: Language not supported
- src/model/Capacitance.h: Language not supported
- src/model/Inductance.cpp: Language not supported
- src/model/Inductance.h: Language not supported
- src/model/Model.cpp: Language not supported
- src/model/Model.h: Language not supported
- src/model/Resistance.cpp: Language not supported
- src/model/Resistance.h: Language not supported
- src/solve/csv_writer.cpp: Language not supported
- tests/cases/dirgraph-results/pulsatileFlow_capacitance_directed_graph.dot: Language not supported
- tests/cases/dirgraph-results/pulsatileFlow_inductance_directed_graph.dot: Language not supported
- tests/cases/dirgraph-results/pulsatileFlow_resistance_directed_graph.dot: Language not supported
- tests/cases/pulsatileFlow_capacitance.json: Language not supported
- tests/cases/pulsatileFlow_inductance.json: Language not supported
- tests/cases/pulsatileFlow_resistance.json: Language not supported
- tests/cases/results/result_pulsatileFlow_capacitance.json: Language not supported
Member
Author
|
Something is wrong with the test. Looking into it |
Member
Author
|
Merging is blocked until #156 is merged. I added a test for the capacitor with (numerically near) zero outflow, which triggered a failure of the current testing code. |
Contributor
|
Now that #166 is merged we can move forward on this! |
Member
Author
|
I'll still need to work on this, but I won't get to it before July. I'll close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Closes #151
Release Notes
Adds simple resistance (R), capacitance (C), and inductance (L) blocks.
Documentation
Added Doxygen for all blocks. @menon-karthik I'm not sure if I need to do anything else for the Python visualization tools.
Testing
Added a test case for each R, C, and L based on analytic solutions.
Code of Conduct & Contributing Guidelines