Skip to content

Conversation

@ncdorn
Copy link
Contributor

@ncdorn ncdorn commented Sep 25, 2025

Current situation

all the files in the .github directory were removed with the last PR so I am adding them back. Additionally we ran into a problem with the latest Eigen commit so we will pin the Eigen version at 3.4.0 for building svZeroDSolver

Release Notes

  • adding .github directory back to the repository
  • pin Eigen version at 3.4.0 for svZeroDSolver build
  • increase solver tolerance for coupledBlock_closedLoopHeart_withCoronaries.json as the test was not passing with the Eigen version change
  • added Install NSIS as a GitHub action for windows OS testing

Documentation

no documentation

Testing

tests are passing

Code of Conduct & Contributing Guidelines

Copy link
Contributor

@aabrown100-git aabrown100-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work!

@aabrown100-git aabrown100-git merged commit 4a95a89 into SimVascular:master Sep 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants