Split Solver.run() function #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality of the former run() function
mrp089
requested changes
Oct 24, 2025
Member
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Looks good, just some minor things
applications/pysvzerod.cpp
Outdated
| .def("run", &Solver::run) | ||
| .def("setup_initial", &Solver::setup_initial) | ||
| .def("setup_integrator", &Solver::setup_integrator) | ||
| .def("run_integration", &Solver::run_integration) |
src/solve/Solver.h
Outdated
| // * | ||
| // */ | ||
| // void run(); | ||
|
|
src/solve/Solver.h
Outdated
| std::vector<double> times; | ||
| State initial_state; | ||
|
|
||
| // Time integration variables added as class variables |
Member
There was a problem hiding this comment.
Remove comment and group new variables with the ones above (e.g. put the states together)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Solver.run() function to be able to run simulations with multiple different time scales
Current situation
It is only possible to have one integrator per simulation, so setting up of simulations that require multiple time scales cannot be implemented.
Release Notes
Testing
All tests run
Code of Conduct & Contributing Guidelines