Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
============================================
+ Coverage 65.45% 68.68% +3.23%
- Complexity 142 154 +12
============================================
Files 14 15 +1
Lines 851 958 +107
Branches 118 138 +20
============================================
+ Hits 557 658 +101
- Misses 250 252 +2
- Partials 44 48 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for positive and negative look-ahead and look-behind patterns in the regex engine, addressing issue #34. The implementation introduces a rewind mechanism to handle cases where lookaround patterns fail to match.
- Adds lookaround pattern support with positive/negative look-ahead/look-behind functionality
- Introduces a rewind mechanism using RewindException for pattern matching failures
- Refactors the API to use string-based matching instead of character-based operations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| CoregexInstances.scala | Refactors shrink implementation using LazyList.unfold for better functional style |
| SetSuite.scala | Updates tests to use new string-based matching API and adds Locale import |
| CoregexSuite.scala | Adds new test cases for literal and group matching functionality |
| CoregexParserSuite.scala | Updates test expectations from UnsupportedOperationException to IllegalStateException |
| CoregexArbitraries.scala | Adds shrink instances for Coregex types and imports option converters |
| Set.java | Removes IntPredicate interface and implements string-based matching |
| RewindException.java | New exception class for handling pattern rewind scenarios |
| CoregexParser.java | Implements parsing logic for lookaround patterns |
| Coregex.java | Major refactoring to support lookaround patterns and string-based matching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/test/scala/com/github/simy4/coregex/core/CoregexSuite.scala
Outdated
Show resolved
Hide resolved
…s for outside scope.
82c22a5 to
0918542
Compare
First implementation for positive/negative look-ahead/look-behind patterns is finally at review stage.
Fixes #34