-
Notifications
You must be signed in to change notification settings - Fork 0
Rename package from colcon-ansi-colors-example to colcon-ansi-colors #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package from colcon-ansi-colors-example to colcon-ansi-colors #1
Conversation
Co-authored-by: mikepurvis <[email protected]>
mikepurvis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the nit, can you also change the section end color not to be black? I think it should be a faint default, assuming the ansi color codes work that way.
mikepurvis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot, please address the prior review feedback
| style.Pictogram = AnsiEscape.Bright + AnsiEscape.Green | ||
| style.SectionStart = AnsiEscape.Default | ||
| style.SectionEnd = AnsiEscape.Bright + AnsiEscape.Black | ||
| style.SectionEnd = AnsiEscape.Faint + AnsiEscape.Default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@mikepurvis Do I understand correctly that you only named the file/class after |
|
@MatthijsBurgh Yes this is only about the colour style for colcon; what it builds and how is completely unaffected. (And to clarify, I’m not the author here, this is a fork of @cottsay’s work linked from colcon/colcon-core#487 (comment)) |

This PR renames the package from
colcon-ansi-colors-exampletocolcon-ansi-colorsthroughout the repository to reflect its final production name.Changes Made
Package Structure
colcon_ansi_colors_example/→colcon_ansi_colors/Configuration Files
Test Files
test_spell_check.pyandtest_flake8.pyto use correct import pathsVerification
The changes are minimal and surgical, preserving all functionality while updating the package identity. The colcon extension continues to work exactly as before, now under the production package name
colcon-ansi-colors.💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.