Skip to content

Conversation

Copy link

Copilot AI commented Aug 7, 2025

This PR renames the package from colcon-ansi-colors-example to colcon-ansi-colors throughout the repository to reflect its final production name.

Changes Made

Package Structure

  • Renamed Python package directory: colcon_ansi_colors_example/colcon_ansi_colors/
  • Updated all import paths and references to use the new package name

Configuration Files

  • setup.cfg: Updated package name, version attribute reference, GitHub URLs, entry points, test suite name, and coverage configuration
  • stdeb.cfg: Updated package name in configuration header
  • README.rst: Updated package title and description

Test Files

  • Updated test files to reference the new package directory structure
  • Modified test_spell_check.py and test_flake8.py to use correct import paths

Verification

  • All existing tests continue to pass
  • Package imports correctly with new name
  • Extension point registration works with colcon-core
  • No references to the old package name remain in the codebase

The changes are minimal and surgical, preserving all functionality while updating the package identity. The colcon extension continues to work exactly as before, now under the production package name colcon-ansi-colors.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Rename package to colcon-ansi-colors Rename package from colcon-ansi-colors-example to colcon-ansi-colors Aug 7, 2025
Copilot AI requested a review from mikepurvis August 7, 2025 05:37
Copilot finished work on behalf of mikepurvis August 7, 2025 05:37
Copy link

@mikepurvis mikepurvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the nit, can you also change the section end color not to be black? I think it should be a faint default, assuming the ansi color codes work that way.

Copy link

@mikepurvis mikepurvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot, please address the prior review feedback

@mikepurvis mikepurvis marked this pull request as ready for review August 7, 2025 22:29
style.Pictogram = AnsiEscape.Bright + AnsiEscape.Green
style.SectionStart = AnsiEscape.Default
style.SectionEnd = AnsiEscape.Bright + AnsiEscape.Black
style.SectionEnd = AnsiEscape.Faint + AnsiEscape.Default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better and more readable on a dark terminal:
Screenshot from 2025-08-07 20-08-20

@MatthijsBurgh
Copy link

@mikepurvis Do I understand correctly that you only named the file/class after catkin_tools as the output is styled like catkin_tools? But it should also work ament builds. Am I Correct?

@mikepurvis mikepurvis merged commit f976afc into main Aug 8, 2025
@mikepurvis
Copy link

@MatthijsBurgh Yes this is only about the colour style for colcon; what it builds and how is completely unaffected.

(And to clarify, I’m not the author here, this is a fork of @cottsay’s work linked from colcon/colcon-core#487 (comment))

@mikepurvis mikepurvis deleted the copilot/fix-9f43f0f6-64bd-49db-953c-7ba729648b6f branch August 8, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants