Skip to content

Conversation

@apurva010
Copy link
Collaborator

…er, and example page

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@apurva010 apurva010 requested a review from aditya-css June 19, 2025 13:18
@apurva010 apurva010 force-pushed the feat/chat_view_list_ui branch from 186d6de to 5a704d2 Compare June 20, 2025 11:43
@apurva010 apurva010 force-pushed the feat/chat_view_list_ui branch from 5a704d2 to c9da40e Compare June 20, 2025 12:35

controller = ChatViewListController(
initialUsersList: initialUsersList,
scrollController: ScrollController(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use PrimaryScrollController.of(context) instead.

this.searchConfig,
this.separatorWidget,
this.padding,
this.chatViewListTileConfig,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the prefix since that's implied by the class name.

/// Creates a configuration object for the chat list UI.
const ChatViewListConfig({
this.searchConfig,
this.separatorWidget,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the suffix here.

});

/// Configuration for the search text field in the chat list.
final SearchConfig? searchConfig;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add ChatView prefix to the model's class name?

final double? extraSpaceAtLast;

/// Configuration for the load more chat list widget.
final LoadMoreChatListConfig? loadMoreChatListConfig;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadMoreConfig would work I believe.

});

/// Configuration for the profile widget.
final ChatViewListTileConfig? chatViewListTileConfig;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a separate isolated config for this widget.

children: [
CircleAvatar(
radius: chatViewListTileConfig?.circleAvatarRadius,
backgroundImage: user.imageUrl == null || user.imageUrl!.isEmpty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cache user.imageUrl in a local variable for better null handling.

super.key,
this.config,
required this.controller,
this.profileWidget,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the widget suffix.

const EdgeInsets.symmetric(vertical: 16.0),
child: Center(
child: widget.loadMoreChatWidget ??
CircularProgressIndicator(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use adaptive version.

return SliverAppBar(
surfaceTintColor: surfaceTintColor,
scrolledUnderElevation: scrolledUnderElevation,
title: Text(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide maxLine and overflow properties here.

@dhyash-simform dhyash-simform force-pushed the feat/chat_view_list_ui branch 12 times, most recently from 798cc9b to 7aacc3e Compare August 4, 2025 11:24
@dhyash-simform dhyash-simform force-pushed the feat/chat_view_list_ui branch from 7aacc3e to 7663d88 Compare August 13, 2025 09:29
@dhyash-simform dhyash-simform force-pushed the feat/chat_view_list_ui branch from 7663d88 to 14110fb Compare August 19, 2025 11:41
@aditya-css aditya-css merged commit ae9ca52 into feat/chat_list_ui_base Aug 19, 2025
@aditya-css aditya-css deleted the feat/chat_view_list_ui branch August 19, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants