feat: ✨ Show Pinned Chat First in ChatViewList #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-chavda
requested changes
Jul 27, 2025
Comment on lines
74
to
79
| final sortCallback = _chatSorterCallback; | ||
| if (sortCallback == null) { | ||
| return chatList; | ||
| } else { | ||
| return chatList..sort(sortCallback); | ||
| } |
Collaborator
There was a problem hiding this comment.
You can leverage if case here.
| /// Provides scroll controller for chat list. | ||
| ScrollController scrollController; | ||
|
|
||
| ChatSorter? _chatSorterCallback; |
Collaborator
There was a problem hiding this comment.
This seems unnecessary.
lib/src/values/enumeration.dart
Outdated
| } | ||
|
|
||
| /// Enum for different chat list sorting options | ||
| enum ChatListSortBy { |
Collaborator
There was a problem hiding this comment.
Please stick to ChatView prefix.
lib/src/values/enumeration.dart
Outdated
| }; | ||
| } | ||
|
|
||
| /// Enum for different chat list sorting options |
Collaborator
There was a problem hiding this comment.
Please mention that this is for internal use only.
dhyash-simform
force-pushed
the
feat/chat_list_show_pinned_chats_first
branch
3 times, most recently
from
4eddfb9 to
9a4c7f5
Compare
aditya-css
approved these changes
Aug 13, 2025
dhyash-simform
force-pushed
the
feat/chat_list_show_pinned_chats_first
branch
from
9a4c7f5 to
9b7ba18
Compare
dhyash-simform
force-pushed
the
feat/chat_list_show_pinned_chats_first
branch
from
9b7ba18 to
7650f01
Compare
aditya-css
approved these changes
Aug 20, 2025
dhyash-simform
added a commit
that referenced
this pull request
Sep 16, 2025
aditya-css
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?