feat: ✨ Add Menu Option for ChatViewList #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhyash-simform
force-pushed
the
feat/chat_list_context_menu
branch
3 times, most recently
from
4be707d to
1fe99d4
Compare
dhyash-simform
force-pushed
the
feat/chat_list_context_menu
branch
from
1fe99d4 to
2525059
Compare
aditya-chavda
requested changes
Aug 17, 2025
Comment on lines
59
to
66
| Future.delayed( | ||
| // Call this after the animation of menu is completed | ||
| // To show the pin status change animation | ||
| const Duration(milliseconds: 800), | ||
| () { | ||
| _chatListController?.removeChat(chat.id); | ||
| }, | ||
| ); |
Collaborator
There was a problem hiding this comment.
This should be rather a callback provided to the user. Also, separately allow user to change the duration.
| loadMoreChats: () async => | ||
| await Future.delayed(const Duration(seconds: 2)), | ||
| menuConfig: ChatMenuConfig( | ||
| enabled: true, |
Collaborator
There was a problem hiding this comment.
This should be default value.
Comment on lines
53
to
59
| final StatusTrailingIcon<MuteStatus>? muteStatusTrailingIcon; | ||
|
|
||
| /// Custom trailing icon for pin status menu item. | ||
| final StatusTrailingIcon<PinStatus>? pinStatusTrailingIcon; | ||
|
|
||
| /// Custom trailing icon for delete menu item. | ||
| final IconData? deleteTrailingIcon; |
Collaborator
There was a problem hiding this comment.
You can drop the trailing word in these.
| final MenuActionBuilder? actions; | ||
|
|
||
| /// Custom menu builder to create the context menu. | ||
| final MenuBuilderCallback? menuBuilder; |
Collaborator
There was a problem hiding this comment.
You can drop the menu prefix here.
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| if (!config.enabled) return child; |
Collaborator
There was a problem hiding this comment.
This widget shouldn't be included in the widget tree if its disabled.
Comment on lines
29
to
32
| final newMuteStatus = switch (chat.settings.muteStatus) { | ||
| MuteStatus.muted => MuteStatus.unmute, | ||
| MuteStatus.unmute => MuteStatus.muted, | ||
| }; |
Collaborator
There was a problem hiding this comment.
You can convert this to a method named toggle in the enum itself.
|
|
||
| final actions = <Widget>[ | ||
| ...?config.actions?.call(chat), | ||
| if (config.muteStatusCallback != null) |
Collaborator
There was a problem hiding this comment.
You can utilise if case here.
| /// Defaults to `ScrollViewKeyboardDismissBehavior.onDrag`. | ||
| final ScrollViewKeyboardDismissBehavior? scrollViewKeyboardDismissBehavior; | ||
|
|
||
| /// Callback to provide a widget for the menu in the chat list. |
Collaborator
There was a problem hiding this comment.
This seems incorrect.
dhyash-simform
force-pushed
the
feat/chat_list_context_menu
branch
from
2525059 to
fe407e4
Compare
dhyash-simform
force-pushed
the
feat/chat_list_context_menu
branch
from
fe407e4 to
c9e32bb
Compare
aditya-css
approved these changes
Aug 20, 2025
dhyash-simform
added a commit
that referenced
this pull request
Sep 16, 2025
aditya-css
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?