feat: ✨ Add Animation in ChatViewList #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhyash-simform
force-pushed
the
feat/animate_on_update_chats
branch
2 times, most recently
from
cfb7bff to
e62a92b
Compare
aditya-chavda
requested changes
Aug 17, 2025
example/lib/chat_operations.dart
Outdated
| sentBy: 'User', | ||
| id: 'msg-${DateTime.now().millisecondsSinceEpoch}', | ||
| ), | ||
| settings: const ChatSettings( |
Collaborator
There was a problem hiding this comment.
This should be default.
Comment on lines
112
to
123
| if (_searchResultMap != null) { | ||
| if (_searchResultMap?.containsKey(chatId) ?? false) { | ||
| _searchResultMap?.remove(chatId); | ||
| if (_chatListStreamController.isClosed) return; | ||
| animatedList.currentState?.removeItemByKey(chatId); | ||
| _chatListStreamController.add(_searchResultMap ?? chatListMap); | ||
| } | ||
| return; | ||
| } | ||
| if (_chatListStreamController.isClosed) return; | ||
| animatedList.currentState?.removeItemByKey(chatId); | ||
| _chatListStreamController.add(chatListMap); |
Collaborator
There was a problem hiding this comment.
Please restructure this.
| _chatListStreamController.add(chatListMap); | ||
| animatedList.currentState?.addChatItem( | ||
| chat, | ||
| isPinned: (item) => item.settings.pinStatus.isPinned, |
Collaborator
There was a problem hiding this comment.
This can be the default function.
Comment on lines
390
to
391
| final message = messages[i]; | ||
| _messageKeys.putIfAbsent(message.id, () => GlobalKey()); |
Collaborator
There was a problem hiding this comment.
This wouldn't run if separator is disabled by the user.
Comment on lines
190
to
192
| : const SizedBox.shrink( | ||
| key: ValueKey('pinIcon-empty'), | ||
| ), |
Collaborator
There was a problem hiding this comment.
You can take this inside of IconScaleAnimation and provide key to icon inside as well.
Comment on lines
220
to
221
| final removedKeys = | ||
| oldPositions.keys.where((key) => !newItemKeys.contains(key)).toList(); |
Collaborator
There was a problem hiding this comment.
I believe you can accommodate this in the above loops.
| ..currentIndex = i; | ||
| } else { | ||
| // New item - only initialize if not already handled by addItem methods | ||
| if (!_itemStates.containsKey(key)) { |
Collaborator
There was a problem hiding this comment.
Please invert the condition for better readability.
Comment on lines
341
to
344
| itemState.moveController.reset(); | ||
| itemState.moveController.forward().then((_) { |
Collaborator
There was a problem hiding this comment.
Please utilise cascade notation.
Comment on lines
394
to
405
| // Create animation controller for new item | ||
| final moveController = AnimationController( | ||
| duration: widget.animationDuration, | ||
| vsync: this, | ||
| ); | ||
|
|
||
| _itemStates[key] = _ItemState<T>( | ||
| moveController: moveController, | ||
| item: newItem, | ||
| currentIndex: position, | ||
| ); | ||
| _itemKeys[key] = GlobalKey(); |
Collaborator
There was a problem hiding this comment.
This section seems to be repeated. Can you please extract it to a function?.
|
|
||
| setState(() { | ||
| // Only animate if new item is added at top and should animate | ||
| if (_isNewItemAddedAtTop) { |
Collaborator
There was a problem hiding this comment.
Please invert the condition for better readability.
dhyash-simform
force-pushed
the
feat/animate_on_update_chats
branch
from
e62a92b to
fd42228
Compare
dhyash-simform
changed the base branch from
main
to
backup/feat/chat_view_list_ui
dhyash-simform
changed the base branch from
backup/feat/chat_view_list_ui
to
feat/chat_list_ui_base
dhyash-simform
force-pushed
the
feat/animate_on_update_chats
branch
5 times, most recently
from
ffe4325 to
679b038
Compare
dhyash-simform
force-pushed
the
feat/animate_on_update_chats
branch
from
679b038 to
02c61a7
Compare
aditya-css
approved these changes
Aug 20, 2025
dhyash-simform
added a commit
that referenced
this pull request
Sep 16, 2025
aditya-css
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?