feat: add settings for WeekView days divider #439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @salahmak Please solve the conflicts in this PR. |
Author
|
@PRBaraiya Should be done |
Author
|
@PRBaraiya ?? |
- Added `weekendDays` parameter to `WeekView` to allow users to specify which days should be considered weekends. - Default value for `weekendDays` is set to `[WeekDays.saturday, WeekDays.sunday]` for backward compatibility. - Updated `_setWeekDays` method to dynamically remove user-specified weekend days when `showWeekends` is false. - Removed hardcoded weekend days (Saturday and Sunday) to make the widget more flexible for different regional or user-specific configurations.
Add support for weekly recurring events that are fixed to weekdays: - Create new WeeklyEvent class for day-of-week based scheduling - Add WeeklyEvent to CalendarEventData conversion - Define constant fixedWeekStart as base reference date - Add helper method addWeeklyEvent to EventController This allows creating events that repeat weekly without being tied to specific calendar dates, useful for regular schedules and timetables.
Add scheduleMode parameter to WeekView widget that enforces a fixed week range: - New boolean parameter scheduleMode (default: false) - When enabled, locks minDay, maxDay, and initialDay to _fixedWeekStart range - Add assertions to prevent setting different date ranges in schedule mode - Update _setDateRange logic to handle schedule mode constraints Complements WeeklyEvent by providing a view mode that displays events in a fixed week context, ideal for viewing recurring schedules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In WeekView, the styling for the Divider between the week days and the week view grid is hard coded (like shown in the screenshot below):
So this PR adds a new class
WeekDaysDividerSettingsto control the styling for that divider, also includes aautoIndentparameter to prevent the divider from taking the entire width and indenting it to start from where the days row starts.Result with autoIndent set to true (with some styles applied through the new settings):
Same result with autoIndent set to false:
This PR also removes the useless hardcoded border below the week days:
Before (autoIndent set to True):
After:
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #374 and #430