Skip to content

Comments

fix: #446 Weekview does reflect changes to startHour and endHour.#447

Closed
bsutton wants to merge 4 commits intoSimformSolutionsPvtLtd:masterfrom
bsutton:weekview
Closed

fix: #446 Weekview does reflect changes to startHour and endHour.#447
bsutton wants to merge 4 commits intoSimformSolutionsPvtLtd:masterfrom
bsutton:weekview

Conversation

@bsutton
Copy link
Contributor

@bsutton bsutton commented Jan 4, 2025

Description

The week view doesn't reflect changes to startHour or endHour when it rebuilds.

Move move both of these values into the InternalWeekView state and update the state when the widget changes.

Checklist

  • [ x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • [ x] I have followed the Contributor Guide when preparing my PR.
  • [ x] I have updated/added tests for ALL new/updated/fixed functionality.
  • [ x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [ x] I have updated/added relevant examples in examples or docs.

Breaking Change?

None

Migration instructions

Not required.

  • Yes, this PR is a breaking change.
  • [x ] No, this PR is not a breaking change.

Related Issues

Closes #446

@Sahil-Simform
Copy link
Contributor

Hi @bsutton,
Thanks for opening this PR. Could you please provide more details about the issue you're facing with startHour and endHour? I tested it in the example app and was able to update startHour successfully, and it appears to be working as expected.

I've attached a video for your reference. Looking forward to your response!

Screen.Recording.2025-06-19.at.2.26.25.PM.mov

@Sahil-Simform Sahil-Simform added the waiting-for-resoponse Waiting for someone to respond. label Jun 19, 2025
@PRBaraiya
Copy link
Collaborator

Closing this PR as the changes does not seem necessary. Please reopen the issue and the PR if this is fixing the issue

@PRBaraiya PRBaraiya closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-resoponse Waiting for someone to respond.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weekview doesn't reflect changes to the start/Hour/endHour

3 participants