fix: #446 Weekview does reflect changes to startHour and endHour.#447
Closed
bsutton wants to merge 4 commits intoSimformSolutionsPvtLtd:masterfrom
Closed
fix: #446 Weekview does reflect changes to startHour and endHour.#447bsutton wants to merge 4 commits intoSimformSolutionsPvtLtd:masterfrom
bsutton wants to merge 4 commits intoSimformSolutionsPvtLtd:masterfrom
Conversation
…startHour and endHour.
Contributor
|
Hi @bsutton, I've attached a video for your reference. Looking forward to your response! Screen.Recording.2025-06-19.at.2.26.25.PM.mov |
Collaborator
|
Closing this PR as the changes does not seem necessary. Please reopen the issue and the PR if this is fixing the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The week view doesn't reflect changes to startHour or endHour when it rebuilds.
Move move both of these values into the InternalWeekView state and update the state when the widget changes.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
None
Migration instructions
Not required.
Related Issues
Closes #446