Skip to content

Conversation

@Zippy-boy
Copy link

@Zippy-boy Zippy-boy commented Mar 3, 2025

Description

Added an option to allow hiding the header. I needed just the weekly view on my app without the option for the user to change week or have the header clog up the view.

New Feature: Hide Header in WeekView

  • Added a new hideHeader flag to the WeekView class to allow users to hide the header.
  • Set the default value of the hideHeader flag to false in the WeekView constructor.
  • Updated the WeekViewState class to conditionally render the header based on the hideHeader flag.

Checklist

  • [ x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • [ x] I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [ x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [ x] I have updated/added relevant examples in examples or docs.

If the PR is breaking, uncomment this header and add instructions for how to migrate from the
currently released version to the new proposed way.
-->

  • Yes, this PR is a breaking change.
  • [x ] No, this PR is not a breaking change.

@Sahil-Simform
Copy link
Contributor

Hi @Zippy-boy, thank you for your contribution!

However, this behaviour can be achieved without introducing a new flag by simply passing SizedBox.shrink() to weekPageHeaderBuilder. So there's no need for the hideHeader flag.

I'm closing this PR for now, but feel free to reach out if you have any questions or need clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants