feat: Fixes issue #382: Add Multi-Day View Support #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I haven’t updated the documentation yet. I would like to confirm the direction first before proceeding with the documentation and further refinements. |
Bonway
changed the title
PRBaraiya
requested changes
Jul 1, 2025
Collaborator
PRBaraiya
left a comment
PRBaraiya
left a comment
There was a problem hiding this comment.
Please check all the comments.
Aside from this, please check and update documentation if necessary, remove unnecessary commented code or add notes if commented code can be reused in future and resolve merge conflicts.
Thanks for raising this PR. We are looking forward to your response.
| daysInView: 3, | ||
| width: width, | ||
| showLiveTimeLineInAllDays: true, | ||
| eventArranger: SideEventArranger(maxWidth: 30), |
Collaborator
There was a problem hiding this comment.
Remove max width from this.
| int getMultiDayDifference( | ||
| {required DateTime startDate, | ||
| required DateTime endDate, | ||
| daysInView = 3}) { |
| required this.heightPerMinute, | ||
| required this.startHour, | ||
| this.endHour = Constants.hoursADay, | ||
| this.onlyShowToday = false}) |
| @override | ||
| Widget build(BuildContext context) { | ||
| final filteredDates = _filteredDate(); | ||
| return Container( |
Collaborator
There was a problem hiding this comment.
can we use sizedbox here?
| : VerticalDirection.down, | ||
| crossAxisAlignment: CrossAxisAlignment.end, | ||
| children: [ | ||
| Container( |
| ), | ||
| SizedBox( | ||
| width: widget.width, | ||
| child: Container( |
| (index) { | ||
| final fullDayEventList = widget.controller | ||
| .getFullDayEvent(filteredDates[index]); | ||
| return Container( |
Collaborator
|
Changes are merged with #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a multi-day view to fulfill my current requirements. Instead of directly modifying the existing week view, I created a new MultiDayView. However, if needed, I can integrate the changes directly into WeekView.
For the week view, I believe that when the app opens in this mode, the first visible day should always be today, while ensuring that navigation and scrolling behaviors align with the expected restrictions.
Currently, I have only utilized properties like showWeek and weekdays, which are not fully applicable to the multi-day view.
Additionally, I noticed your other branch that implements a 3-day view, but it has a bug where the selected date does not match the navigation target. The core issue seems to stem from relying directly on the number of days in a week for calculations, which causes inconsistencies.
I have also added a single-day timeline display, as well as a bottom line beneath the weekly view for better visual clarity.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Migration instructions
Related Issues
Closes #382