feat: ✨ Tooltip actions' horizontal placement #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds horizontal positioning capabilities for tooltip action buttons, expanding from just inside/outside placement to also support left and right positioning within the tooltip container.
- Added new enum values
insideLeftandinsideRighttoTooltipActionPosition - Refactored tooltip content rendering to support both vertical and horizontal action layouts
- Added
mainAxisSizeconfiguration parameter toTooltipActionConfig
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/src/utils/enum.dart | Added insideLeft and insideRight enum values with helper methods for positioning logic |
| lib/src/widget/action_widget.dart | Removed redundant parameters and added conditional Row/Column layout based on position |
| lib/src/tooltip/tooltip_wrapper.dart | Renamed class from ToolTipWidget to ToolTipWrapper and extracted content to separate widget |
| lib/src/tooltip/tooltip_content.dart | New widget handling tooltip content layout with horizontal/vertical action positioning |
| lib/src/models/tooltip_action_config.dart | Added mainAxisSize property with equality and hashCode updates |
| lib/src/showcase/showcase_controller.dart | Updated action gap logic to handle horizontal positioning |
| lib/src/showcase/showcase.dart | Added assertions for required title/description parameters |
| example/lib/main.dart | Updated example to demonstrate insideRight positioning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| required this.description, | ||
| required this.child, | ||
| this.title, | ||
| this.description, |
There was a problem hiding this comment.
The description parameter should remain required to maintain backward compatibility. Making it optional without a major version bump could break existing implementations that rely on the required nature of this parameter.
Suggested change
| this.description, | |
| required this.description, |
Copilot uses AI. Check for mistakes.
- Added `insideLeft` and `insideRight` values in `TooltipActionPosition` enum. - Removed redundant parameters in `ActionWidget`. - Added proper assertions in `Showcase`. - Added `mainAxisSize` in `TooltipActionConfig`.
aditya-css
force-pushed
the
feature/tooltip_action_inside_horizontal
branch
from
a08d637 to
c50450d
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
insideLeftandinsideRightvalues inTooltipActionPositionenum.ActionWidget.Showcase.mainAxisSizeinTooltipActionConfig.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues