Skip to content

feature: decouple audio recorder hooks methods from waveform UI component #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: feature/decouple-UI-logic
Choose a base branch
from
Draft

feature: decouple audio recorder hooks methods from waveform UI component #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd5f6b
feat(UNT-T32722): decouple recorder methods from waveform component
kuldip-simform Feb 28, 2025
fbc72ef
feat: improve error handling for stop audio recorder method
kuldip-simform Feb 28, 2025
6fcbe47
feat: fix code formatting and get decimal method
kuldip-simform Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions android/src/main/java/com/audiowaveform/AudioRecorder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.Manifest
import android.app.Activity
import android.content.pm.PackageManager
import android.media.MediaMetadataRetriever
import android.media.MediaPlayer
import android.media.MediaRecorder
import android.os.Build
import android.util.Log
Expand Down Expand Up @@ -54,10 +55,10 @@ class AudioRecorder {
}

fun getDecibel(recorder: MediaRecorder?): Double? {
if (useLegacyNormalization) {
if (recorder != null) {
if (recorder != null) {
if (useLegacyNormalization) {
try {
val db = 20 * log10((recorder?.maxAmplitude?.toDouble() ?: (0.0 / 32768.0)))
val db = 20 * log10((recorder.maxAmplitude.toDouble() ?: (0.0 / 32768.0)))
if (db == Double.NEGATIVE_INFINITY) {
Log.e(Constants.LOG_TAG, "Microphone might be turned off")
} else {
Expand All @@ -68,21 +69,16 @@ class AudioRecorder {
e.printStackTrace()
return null
}
}
else {
return null
}
} else {
if (recorder != null) {
} else {
try {
return recorder?.maxAmplitude?.toDouble() ?: 0.0
return recorder.maxAmplitude.toDouble() ?: 0.0
} catch (e: IllegalStateException) {
e.printStackTrace()
return null
}
} else {
return null
}
} else {
return null
}
}

Expand Down Expand Up @@ -114,7 +110,10 @@ class AudioRecorder {
promise.resolve(true)
} catch (e: IllegalArgumentException) {
Log.e(Constants.LOG_TAG, "Invalid MediaRecorder configuration", e)
promise.reject("CONFIGURATION_ERROR", "Invalid MediaRecorder configuration: ${e.message}")
promise.reject(
"CONFIGURATION_ERROR",
"Invalid MediaRecorder configuration: ${e.message}"
)
} catch (e: IOException) {
Log.e(Constants.LOG_TAG, "Failed to stop initialize recorder")
}
Expand All @@ -130,34 +129,40 @@ class AudioRecorder {
release()
}
isRecording = false
val tempArrayForCommunication : MutableList<String> = mutableListOf()
val duration = getDuration(path)
tempArrayForCommunication.add(path)
tempArrayForCommunication.add(duration.toString())
promise.resolve(Arguments.fromList(tempArrayForCommunication))
val response = Arguments.createArray().apply {
pushString(path)
pushString(duration.toString())
}

promise.resolve(response)

} else {
promise.reject("Error", "Recorder is not recording or has already been stopped")
}
} catch (e: IllegalStateException) {
Log.e(Constants.LOG_TAG, "Failed to stop recording",e)
Log.e(Constants.LOG_TAG, "Failed to stop recording", e)
} catch (e: RuntimeException) {
Log.e(Constants.LOG_TAG, "Runtime exception when stopping recording", e)
promise.reject("Error", "Runtime exception: ${e.message}")
}
}

private fun getDuration(path: String): String {
val mediaMetadataRetriever = MediaMetadataRetriever()
try {
mediaMetadataRetriever.setDataSource(path)
val duration = mediaMetadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_DURATION)
return duration ?: "-1"
/**
* Helper function to get the actual audio duration.
*/
private fun getDuration(filePath: String): Int {
val mediaPlayer = MediaPlayer()
return try {
mediaPlayer.setDataSource(filePath)
mediaPlayer.prepare()
val duration = mediaPlayer.duration
mediaPlayer.release()
duration
} catch (e: Exception) {
Log.e(Constants.LOG_TAG, "Failed to get recording duration")
} finally {
mediaMetadataRetriever.release()
Log.e(Constants.LOG_TAG, "Failed to get audio duration", e)
0
}
return "-1"
}

fun startRecorder(recorder: MediaRecorder?, useLegacy: Boolean, promise: Promise) {
Expand Down Expand Up @@ -210,6 +215,7 @@ class AudioRecorder {
MediaRecorder.AudioEncoder.AAC
}
}

Constants.vorbis -> MediaRecorder.AudioEncoder.VORBIS
else -> MediaRecorder.AudioEncoder.AAC
}
Expand All @@ -227,17 +233,22 @@ class AudioRecorder {
MediaRecorder.OutputFormat.MPEG_4
}
}

Constants.amr_wb -> MediaRecorder.OutputFormat.AMR_WB
Constants.amr_nb -> MediaRecorder.OutputFormat.AMR_NB
Constants.webm -> MediaRecorder.OutputFormat.WEBM
Constants.mpeg_2_ts -> {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
MediaRecorder.OutputFormat.MPEG_2_TS
} else {
Log.e(Constants.LOG_TAG, "Minimum android Q is required, Setting MPEG_4 output format.")
Log.e(
Constants.LOG_TAG,
"Minimum android Q is required, Setting MPEG_4 output format."
)
MediaRecorder.OutputFormat.MPEG_4
}
}

Constants.aac_adts -> MediaRecorder.OutputFormat.AAC_ADTS
else -> MediaRecorder.OutputFormat.MPEG_4
}
Expand Down
Loading