Skip to content

better error when null cant be converted #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

better error when null cant be converted #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<NoWarn>CS1591;NU5104;CS1573;CS9107;NU1608;NU1109</NoWarn>
<Version>31.0.0</Version>
<Version>31.0.1</Version>
<LangVersion>preview</LangVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<PackageTags>EntityFrameworkCore, EntityFramework, GraphQL</PackageTags>
Expand Down
9 changes: 7 additions & 2 deletions src/GraphQL.EntityFramework/Where/TypeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,11 @@ static List<T> GetEnumList<T>(IEnumerable<string> values)
type = underlyingType;
}

if (value is null)
{
throw new($"Expected value to be convertible to {type}. However it was null. It is possible a required variable was not provided");
}

if (type == typeof(DateTime))
{
return ValueConverter.ConvertTo<DateTime>(value);
Expand All @@ -225,12 +230,12 @@ static List<T> GetEnumList<T>(IEnumerable<string> values)

if (type == typeof(Guid))
{
return new Guid(value!);
return new Guid(value);
}

if (type.IsEnum)
{
return Enum.Parse(type, value!, true);
return Enum.Parse(type, value, true);
}

return Convert.ChangeType(value, type);
Expand Down